feat!: add design tokens support - #2187
Merged
Merged
Conversation
…-tokens Sync master to design tokens
Conflicts: src/library-authoring/components/BaseCard.scss src/library-authoring/units/index.scss
Conflicts: src/generic/block-type-utils/index.scss
Conflicts: src/optimizer-page/scan-results/BrokenLinkTable.tsx
Conflicts: package-lock.json src/library-authoring/units/index.scss
Conflicts: src/generic/inplace-text-editor/index.tsx
Conflicts: package-lock.json
Conflicts: src/editors/sharedComponents/SelectionModal/__snapshots__/GalleryCard.test.jsx.snap
…gn-tokens-sync sync `master` -> `master-design-tokens`
Conflicts: package-lock.json
…-tokens-sync sync `master` -> `master-design-tokens`
brian-smith-tcril
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2187 +/- ##
=======================================
Coverage 94.08% 94.08%
=======================================
Files 1164 1164
Lines 24489 24491 +2
Branches 5312 5309 -3
=======================================
+ Hits 23041 23043 +2
Misses 1371 1371
Partials 77 77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sync `master` -> `master-design-tokens`
brian-smith-tcril
marked this pull request as ready for review
June 18, 2025 18:33
| @@ -1,5 +1,4 @@ | |||
| @import "~@edx/brand/paragon/variables"; | |||
| @import "~@openedx/paragon/scss/core/utilities-only"; | |||
| @import "~@openedx/paragon/styles/scss/core/utilities-only"; | |||
Contributor
Author
There was a problem hiding this comment.
TODO: Create issue to clean this up. TL;DR for the issue - don't use this, directly use css vars.
adamstankiewicz
approved these changes
Jun 18, 2025
This was referenced Jun 18, 2025
sync `master` -> `master-design-tokens`
Asespinel
pushed a commit
to eduNEXT/frontend-app-authoring
that referenced
this pull request
Jul 30, 2025
BREAKING CHANGE: Pre-design-tokens theming is no longer supported. Co-authored-by: Diana Olarte <diana.olarte@edunext.co>
andrey-canon
pushed a commit
to nelc/frontend-app-authoring
that referenced
this pull request
Oct 10, 2025
BREAKING CHANGE: Pre-design-tokens theming is no longer supported. Co-authored-by: Diana Olarte <diana.olarte@edunext.co>
xitij2000
pushed a commit
to open-craft/frontend-app-authoring
that referenced
this pull request
Dec 17, 2025
BREAKING CHANGE: Pre-design-tokens theming is no longer supported. Co-authored-by: Diana Olarte <diana.olarte@edunext.co>
xitij2000
pushed a commit
to open-craft/frontend-app-authoring
that referenced
this pull request
Dec 19, 2025
BREAKING CHANGE: Pre-design-tokens theming is no longer supported. Co-authored-by: Diana Olarte <diana.olarte@edunext.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Pre-design-tokens theming is no longer supported.
LAND AS SQUASH
The
master-design-tokensbranches were created as long running feature branches to ensure design tokens land on all MFEs simultaneously. These have been kept up to date via merge commits and should land on their respective MFEmasterbranches as a single squashed commit.master->master-design-tokens#2188