Skip to content

fix: don't import scss vars from brand package - #2026

Merged
brian-smith-tcril merged 1 commit into
openedx:master-design-tokensfrom
brian-smith-tcril:remove-brand-scss-import
May 22, 2025
Merged

fix: don't import scss vars from brand package#2026
brian-smith-tcril merged 1 commit into
openedx:master-design-tokensfrom
brian-smith-tcril:remove-brand-scss-import

Conversation

@brian-smith-tcril

Copy link
Copy Markdown
Contributor

Description

We shouldn't be importing this from @edx/brand. Paragon's utilities-only.scss imports variables. Paragon's _variables.scss ensures the scss variables in this file compile to read css variables. Brand packages provide css variables.

@adamstankiewicz adamstankiewicz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov

codecov Bot commented May 22, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.89%. Comparing base (d775096) to head (435cecd).
Report is 2 commits behind head on master-design-tokens.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           master-design-tokens    #2026    +/-   ##
======================================================
  Coverage                 93.89%   93.89%            
======================================================
  Files                      1154     1154            
  Lines                     24061    24061            
  Branches                   5200     5096   -104     
======================================================
  Hits                      22592    22592            
  Misses                     1401     1401            
  Partials                     68       68            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brian-smith-tcril
brian-smith-tcril merged commit 6bb3697 into openedx:master-design-tokens May 22, 2025
luisfelipec95 pushed a commit to eduNEXT/frontend-app-course-authoring that referenced this pull request Jul 4, 2025
luisfelipec95 pushed a commit to eduNEXT/frontend-app-course-authoring that referenced this pull request Jul 4, 2025
luisfelipec95 pushed a commit to eduNEXT/frontend-app-course-authoring that referenced this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants