fix: don't import scss vars from brand package - #2026
Merged
brian-smith-tcril merged 1 commit intoMay 22, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master-design-tokens #2026 +/- ##
======================================================
Coverage 93.89% 93.89%
======================================================
Files 1154 1154
Lines 24061 24061
Branches 5200 5096 -104
======================================================
Hits 22592 22592
Misses 1401 1401
Partials 68 68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
luisfelipec95
pushed a commit
to eduNEXT/frontend-app-course-authoring
that referenced
this pull request
Jul 4, 2025
luisfelipec95
pushed a commit
to eduNEXT/frontend-app-course-authoring
that referenced
this pull request
Jul 4, 2025
luisfelipec95
pushed a commit
to eduNEXT/frontend-app-course-authoring
that referenced
this pull request
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We shouldn't be importing this from
@edx/brand. Paragon'sutilities-only.scssimportsvariables. Paragon's_variables.scssensures the scss variables in this file compile to read css variables. Brand packages provide css variables.