fix: Subsections should come before Sections - #2185
Merged
Merged
Conversation
Member
Author
|
@rpenido Can you review this? |
Member
Author
|
@sdaitzman I presume this is the desired behavior, but let me know if I'm wrong. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2185 +/- ##
=========================================
Coverage ? 94.08%
=========================================
Files ? 1164
Lines ? 24481
Branches ? 5306
=========================================
Hits ? 23033
Misses ? 1371
Partials ? 77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@kdmccormick thanks for confirming, yes. The "after" order is correct. |
rpenido
approved these changes
Jun 17, 2025
Contributor
There was a problem hiding this comment.
LGTM 👍
Thanks @kdmccormick!
- I tested this by opening the library page and checking the tabs order
- I read through the code
- I checked for accessibility issues
- Includes documentation
PS: I don't have merge rights on this repository, so you probably need someone to merge it here. CC @ChrisChV @bradenmacdonald
bradenmacdonald
approved these changes
Jun 18, 2025
bradenmacdonald
left a comment
bradenmacdonald
left a comment
Contributor
There was a problem hiding this comment.
LGTM but hold off on merging until #2187 is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Subsections are bigger than Units and smaller than Sections, so the order of the library authoring tabs should be: Units, Subsections, Sections. Before this PR, the order was: Units, Sections, Subsections.
Supporting information
Before
After