feat: optionally collect JS translations on deploy - #6708
Conversation
|
Thanks for the pull request, @mtyaka! I've created OSPR-6553 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
c1b2d54 to
a3cc64f
Compare
|
@mtyaka Thank you for your contribution. Please let me know once it is ready for our review. |
farhaanbukhsh
left a comment
There was a problem hiding this comment.
👍
- ✅ I tested this: on the sandbox and saw the configuration
- ✅ I read through the code
- ❌ I checked for accessibility issues
- ❌ Includes documentation
- ❌ I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository.
|
@natabene This is ready for review. |
|
@mtyaka Can you please rebase the PR? thanks |
If the EDXAPP_COMPILE_JSI18N is enabled, this will invoke the compilejsi18n management command when deploying edxapp. This is useful when you use custom JS translations for example via a theme.
a3cc64f to
1fbdc9a
Compare
|
@nadeemshahzad Thanks for looking at this. I rebased it and resolved the conflicts. |
|
@mtyaka 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
…-5140-collect-js-translations feat: optionally collect JS translations on deploy (cherry picked from commit 371e360)
…-5140-collect-js-translations feat: optionally collect JS translations on deploy (cherry picked from commit 371e360)
…-5140-collect-js-translations feat: optionally collect JS translations on deploy (cherry picked from commit 371e360)
If the
EDXAPP_COMPILE_JSI18Nis enabled, this will invoke thecompilejsi18nmanagement command when deploying edxapp.This is useful when you use custom JS translations for example via a theme.
Test instructions:
I set up a sandbox using code from #6679 to automatically install some custom JS translations. These are the relevant ansible vars:
ar)./edx/app/edxapp/edx-platformfolder and rungit status. You should see some modified files underlms/static/js/i18n(the files were modified because thecompilejsi18nmanagement comment modifies them after collecting JS translations fromLOCALE_PATHS).Sandbox:
Configuration Pull Request
Make sure that the following steps are done before merging: