This repository was archived by the owner on Aug 3, 2026. It is now read-only.
feat: optionally collect JS translations on deploy - #188
Merged
mtyaka merged 1 commit intoApr 4, 2022
Conversation
If the EDXAPP_COMPILE_JSI18N is enabled, this will invoke the compilejsi18n management command when deploying edxapp. This is useful when you use custom JS translations for example via a theme.
mtyaka
force-pushed
the
mtyaka/SE-5140-simple-theme-i18n-lilac
branch
from
March 30, 2022 09:10
5f708ab to
4bb4424
Compare
farhaanbukhsh
approved these changes
Apr 4, 2022
farhaanbukhsh
left a comment
farhaanbukhsh
left a comment
Member
There was a problem hiding this comment.
👍
- ✅ I tested the upstream changes.
- ✅ I read through the code
- ❌ I checked for accessibility issues
- ❌ Includes documentation
- ❌ I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository.
Member
Author
|
Thanks @farhaanbukhsh! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
EDXAPP_COMPILE_JSI18Nis enabled, this will invoke thecompilejsi18nmanagement command when deploying edxapp.This is useful when you use custom JS translations for example via a theme.
This cherry-picks changes from openedx-unsupported#6708