feat: add SIMPLETHEME_I18N_DJANGO variable - #6679
Conversation
|
Thanks for the pull request, @mtyaka! I've created OSPR-6430 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
9cc33f3 to
41b5644
Compare
41b5644 to
bed978c
Compare
|
@mtyaka Thank you for your contribution. Is this ready for our review? |
|
Thanks for checking @natabene! I'm waiting for a couple of dependencies to get merged before I'll mark this ready for review. I'll ping you when it's ready. |
bed978c to
c84cfd2
Compare
farhaanbukhsh
left a comment
There was a problem hiding this comment.
👍
- ✅ I tested this on the sandbox and looked at the configuration and translations.
- ✅ I read through the code
- ❌ I checked for accessibility issues
- ❌ Includes documentation
- ❌ I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository.
|
@natabene This is now ready for review. |
|
@mtyaka I've skimmed this PR and believe it looks reasonable, however I'm not familiar with the pros and cons of this approach over other approaches, so I'd like to discuss it with our the edX SRE team. Would you also mind rebasing it to resolve the conflicts if you have a moment to do so? |
This makes it possible to add or override django translations via the simple-theme role.
c84cfd2 to
1e55e8a
Compare
|
@mtyaka 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
…-5140-simple-theme-i18n feat: add SIMPLETHEME_I18N_DJANGO variable (cherry picked from commit ae8100e)
…-5140-simple-theme-i18n feat: add SIMPLETHEME_I18N_DJANGO variable (cherry picked from commit ae8100e)
…-5140-simple-theme-i18n feat: add SIMPLETHEME_I18N_DJANGO variable (cherry picked from commit ae8100e)
…-5140-simple-theme-i18n feat: add SIMPLETHEME_I18N_DJANGO variable (cherry picked from commit ae8100e)
This makes it possible to add or override django translations via the simple-theme role.
This adds a new
SIMPLETHEME_I18N_DJANGOconfiguration variable to thesimple_themerole, which makes it possible to set or override theme translations via configuration variables without having to check po/mo files into any theme repo. When combined with theEDXAPP_PREPEND_LOCALE_PATHSvariable, it can also be used to override default edx-platform translations.Test instructions
ar).Note: the sandbox is running lilac. It was provisioned with this patch cherry-picked into the lilac branch (without any conflicts).
Sandbox:
The sandbox was provisioned with the following settings:
Configuration Pull Request
Make sure that the following steps are done before merging: