Skip to content
This repository was archived by the owner on Aug 3, 2026. It is now read-only.

feat: add SIMPLETHEME_I18N_DJANGO variable - #187

Merged
mtyaka merged 1 commit into
opencraft-release/lilac.2from
mtyaka/SE-5140-simple-theme-i18n-lilac
Mar 24, 2022
Merged

feat: add SIMPLETHEME_I18N_DJANGO variable#187
mtyaka merged 1 commit into
opencraft-release/lilac.2from
mtyaka/SE-5140-simple-theme-i18n-lilac

Conversation

@mtyaka

@mtyaka mtyaka commented Mar 24, 2022

Copy link
Copy Markdown
Member

This makes it possible to add or override django translations via the simple-theme role.

This cherry-picks changes from openedx-unsupported#6679 into the opencraft-release/lilac.2 branch.

This makes it possible to add or override django translations via the
simple-theme role.
@mtyaka
mtyaka requested a review from farhaanbukhsh March 24, 2022 07:26

@farhaanbukhsh farhaanbukhsh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • ✅ I tested this on the lilac sandbox on the upstream PR
  • ✅ I read through the code
  • ❌ I checked for accessibility issues
  • ❌ Includes documentation
  • ❌ I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@mtyaka
mtyaka merged commit 3d6a26f into opencraft-release/lilac.2 Mar 24, 2022
@mtyaka
mtyaka deleted the mtyaka/SE-5140-simple-theme-i18n-lilac branch March 24, 2022 08:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants