Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add networkpolicy in dsci #590

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Oct 3, 2023

Description

ref #423

How Has This Been Tested?

local build :
http://quay.io/wenzhou/opendatahub-operator-catalog:v2.10.423-10

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@zdtsw zdtsw requested review from asanzgom and jgarciao and removed request for LaVLaS and VaishnaviHire October 3, 2023 13:07
@zdtsw
Copy link
Member Author

zdtsw commented Oct 3, 2023

@asanzgom is helping to do verification, i will leave him to comment on with test result.

@asanzgom
Copy link
Contributor

asanzgom commented Oct 3, 2023

So far I checked on an AWS Cluster the installation of the http://quay.io/wenzhou/opendatahub-operator-catalog:v2.10.423-10 image and was able to access ODH dashboard:

image

Here I leave the networkpolicy-opendatahub.yaml :

apiVersion: networking.k8s.io/v1
metadata:
  name: opendatahub
  namespace: opendatahub
  uid: 0d0c50dd-2ff0-4c69-b6f0-8b6840f2b480
  resourceVersion: '397359'
  generation: 1
  creationTimestamp: '2023-10-03T12:49:35Z'
  ownerReferences:
    - apiVersion: dscinitialization.opendatahub.io/v1
      kind: DSCInitialization
      name: default
      uid: d6c9aba5-9d52-4570-858e-35de6b0e8d06
      controller: true
      blockOwnerDeletion: true
  managedFields:
    - manager: manager
      operation: Update
      apiVersion: networking.k8s.io/v1
      time: '2023-10-03T12:49:35Z'
      fieldsType: FieldsV1
      fieldsV1:
        'f:metadata':
          'f:ownerReferences':
            .: {}
            'k:{"uid":"d6c9aba5-9d52-4570-858e-35de6b0e8d06"}': {}
        'f:spec':
          'f:ingress': {}
          'f:policyTypes': {}
spec:
  podSelector: {}
  ingress:
    - from:
        - namespaceSelector:
            matchLabels:
              opendatahub.io/generated-namespace: 'true'
    - from:
        - namespaceSelector:
            matchLabels:
              kubernetes.io/metadata.name: openshift-ingress
  policyTypes:
    - Ingress
status: {}

Now trying to test on a PSI Cluster

@zdtsw zdtsw added the odh-1.11 label Oct 3, 2023
Copy link

@jgarciao jgarciao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the livebuild in an OpenStack cluster and it worked well

@openshift-ci
Copy link

openshift-ci bot commented Oct 3, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asanzgom, jgarciao
Once this PR has been reviewed and has the lgtm label, please assign vaishnavihire for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw merged commit fddbe0e into opendatahub-io:incubation Oct 3, 2023
1 of 2 checks passed
@asanzgom
Copy link
Contributor

asanzgom commented Oct 3, 2023

Test on PSI Cluster by @jgarciao went fine, also spawned notebooks correctly

@VaishnaviHire
Copy link
Member

@zdtsw Just want to confirm if there were any failures in pipelines, data science projects or any other components

@zdtsw
Copy link
Member Author

zdtsw commented Oct 3, 2023

@zdtsw Just want to confirm if there were any failures in pipelines, data science projects or any other components

i think we can run odh nightly on the build to ensure no error from this change, this will not be sync to downstream till all cases are verified.
but from QE said, they did not see other errors.

@bartoszmajsak
Copy link
Contributor

@zdtsw I think this should be changed to It then #584 (comment)

@zdtsw
Copy link
Member Author

zdtsw commented Oct 3, 2023

@zdtsw I think this should be changed to It then #584 (comment)

correct! thanks for bringing this up.

VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Oct 10, 2023
zdtsw added a commit that referenced this pull request Oct 12, 2023
* fix: adds missing CRDs and installs them for testenv

- introduces make func to download needed CRDs to config/crd/external when running make manifests target
- adds missing scheme installation in test setup
- marks one test as Pending due to NetworkPolicies being disabled right now

* fix: passes ns when creating UserGroup resource

* chore: updates CRD download func

* Linter: add golangci-linter and fix issues (#540)

- Update Makefile
- Add linter in GH action and make target to download binary
 - set timeout for 5m for GH aciton when cache is not hit
 - set to use 1.54.0 of golangci-lint
 - add lll linter and set to 180, skip lines out of range
 - set max-complicity back to default 30, skip lines out of scope
 - disable degarud linter
Fix linter after adding function test on DSCI

Signed-off-by: Wen Zhou <[email protected]>
Co-authored-by: Bartosz Majsak <[email protected]>

* feat(manifests): allows configuring manifest repositories using flags (#585)

* feat(manifests): allows configuring manifest repos using flags
* feat(docs): extended section about usage of get_all_manifests script
* chore: prints available components when key does not match
* chore(docs): updates manifests customization

* Feature: add networkpolicy in dsci (#590)

Signed-off-by: Wen Zhou <[email protected]>

* fix(crds): updates docs after godoc fixes (#594)

* Enable test case after networkpolicy is added (#592)

* fix(make): removes duplicated e2e flag declaration (#595)

* chore: removes GetComponentDevFlags as it is exported field of the struct (#591)

and it is already accessed this way.

* fix: populate entire dscispec (#597)

* Update Dashboard branch in incubation (#598)

* Remove sync dashboard CRD since we do not have CRD any more (#599)

Signed-off-by: Wen Zhou <[email protected]>

* feat: uses reflect to reconcile defined components (#593)

* feat: uses reflect to reconcile defined components

This way we do not have to add call in reconcile for newly created component as it will be handled automatically.

* chore: reworks component collection to return slice

* chore: organizes code in dashboard component (#589)

* chore: organizes code in dashboard component

extracts certain config/deployment work to their own funcs for better readability

* fix: removes unused directive

* fix: removes duplicated interface conformance check

* fix(lint): removes extra line

* Auto Add Issues to Tracking boards (#601)

* Add check on the replace image on the component level overwrite (#583)

Signed-off-by: Wen Zhou <[email protected]>

* Fix autoadd issues (#611)

* Add github workflows (#564)

* add github workflows
* update make cmd for unit-test

* fix(make): test is renamed to unit-test (#624)

Signed-off-by: Wen Zhou <[email protected]>

* Update common monitoring config

* Add feature/functional tests in DSCInitialization

---------

Signed-off-by: Wen Zhou <[email protected]>
Co-authored-by: bartoszmajsak <[email protected]>
Co-authored-by: Wen Zhou <[email protected]>
Co-authored-by: Ajay Pratap <[email protected]>
Co-authored-by: AJAY_JAGANATHAN <[email protected]>
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Oct 20, 2023
Signed-off-by: Wen Zhou <[email protected]>
(cherry picked from commit fddbe0e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants