fix: adds missing CRDs for k8s EnvTest #584
Conversation
- introduces make func to download needed CRDs to config/crd/external when running make manifests target - adds missing scheme installation in test setup - marks one test as Pending due to NetworkPolicies being disabled right now
| @@ -48,7 +48,8 @@ var _ = Describe("DataScienceCluster initialization", func() { | |||
| Expect(foundMonitoringNamespace.Name).Should(Equal(monitoringNamespace)) | |||
| }) | |||
|
|
|||
| It("Should create default network policy", func() { | |||
| // Currently commented out in the DSCI reconcile - setting test to Pending | |||
| PIt("Should create default network policy", func() { | |||
There was a problem hiding this comment.
Yes, otherwise the test will fail as the code for creating NetworkPolicy is commented out. PIt - marks test case as Pending in the execution report. You can also XIt - exclude it, and FIt - focus test suite to run only tests with F
There was a problem hiding this comment.
I was hoping that the comment one line above makes it clear :)
There was a problem hiding this comment.
ah, nice ! new things learnt every day
There was a problem hiding this comment.
Thanks for the PR @bartoszmajsak
Just a note, this did not show up in CI, as we directly to docker build.. in CI job.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VaishnaviHire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
After latest merges EvnTest tests stopped working. This PR addresses the problems by:
config/crd/externalwhen runningmake manifeststargetHow Has This Been Tested?
make testMerge criteria: