feat(manifests): allows configuring manifest repositories using flags #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. one can now call ``` get_all_manifests.sh --odh-dashboard="cam-garrison:odh-dashboard:test-manifests:manifests:odh-dashboard" ``` which will also work when building an image through build-args: ``` make image IMAGE_BUILD_FLAGS=" --build-arg USE_LOCAL=false --build-arg OVERWRITE_MANIFESTS='--odh-dashboard="cam-garrison:odh-dashboard:test-manifests:manifests:odh-dashboard"'" ```
|
would like to have updates in https://github.com/maistra/opendatahub-operator/blob/get_manifests_config/README.md#download-manifests, any maybe add the example usage as well |
Thanks for this suggestion @zdtsw. In 7868e39 I extended the docs. In addition, commit 8678660 enhances the way how flags are handled, so in case if you pass non existing |
zdtsw
reviewed
Oct 3, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Oct 10, 2023
…opendatahub-io#585) * feat(manifests): allows configuring manifest repos using flags * feat(docs): extended section about usage of get_all_manifests script * chore: prints available components when key does not match * chore(docs): updates manifests customization
zdtsw
added a commit
that referenced
this pull request
Oct 12, 2023
* fix: adds missing CRDs and installs them for testenv - introduces make func to download needed CRDs to config/crd/external when running make manifests target - adds missing scheme installation in test setup - marks one test as Pending due to NetworkPolicies being disabled right now * fix: passes ns when creating UserGroup resource * chore: updates CRD download func * Linter: add golangci-linter and fix issues (#540) - Update Makefile - Add linter in GH action and make target to download binary - set timeout for 5m for GH aciton when cache is not hit - set to use 1.54.0 of golangci-lint - add lll linter and set to 180, skip lines out of range - set max-complicity back to default 30, skip lines out of scope - disable degarud linter Fix linter after adding function test on DSCI Signed-off-by: Wen Zhou <[email protected]> Co-authored-by: Bartosz Majsak <[email protected]> * feat(manifests): allows configuring manifest repositories using flags (#585) * feat(manifests): allows configuring manifest repos using flags * feat(docs): extended section about usage of get_all_manifests script * chore: prints available components when key does not match * chore(docs): updates manifests customization * Feature: add networkpolicy in dsci (#590) Signed-off-by: Wen Zhou <[email protected]> * fix(crds): updates docs after godoc fixes (#594) * Enable test case after networkpolicy is added (#592) * fix(make): removes duplicated e2e flag declaration (#595) * chore: removes GetComponentDevFlags as it is exported field of the struct (#591) and it is already accessed this way. * fix: populate entire dscispec (#597) * Update Dashboard branch in incubation (#598) * Remove sync dashboard CRD since we do not have CRD any more (#599) Signed-off-by: Wen Zhou <[email protected]> * feat: uses reflect to reconcile defined components (#593) * feat: uses reflect to reconcile defined components This way we do not have to add call in reconcile for newly created component as it will be handled automatically. * chore: reworks component collection to return slice * chore: organizes code in dashboard component (#589) * chore: organizes code in dashboard component extracts certain config/deployment work to their own funcs for better readability * fix: removes unused directive * fix: removes duplicated interface conformance check * fix(lint): removes extra line * Auto Add Issues to Tracking boards (#601) * Add check on the replace image on the component level overwrite (#583) Signed-off-by: Wen Zhou <[email protected]> * Fix autoadd issues (#611) * Add github workflows (#564) * add github workflows * update make cmd for unit-test * fix(make): test is renamed to unit-test (#624) Signed-off-by: Wen Zhou <[email protected]> * Update common monitoring config * Add feature/functional tests in DSCInitialization --------- Signed-off-by: Wen Zhou <[email protected]> Co-authored-by: bartoszmajsak <[email protected]> Co-authored-by: Wen Zhou <[email protected]> Co-authored-by: Ajay Pratap <[email protected]> Co-authored-by: AJAY_JAGANATHAN <[email protected]>
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Oct 20, 2023
…opendatahub-io#585) * feat(manifests): allows configuring manifest repos using flags * feat(docs): extended section about usage of get_all_manifests script * chore: prints available components when key does not match * chore(docs): updates manifests customization (cherry picked from commit 0214bb3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As we are working on adding Service Mesh bits to the new operator I enhanced the manifests script so now one can call it using flags being named after components and pass alternative location. Please note it now also has repo org/user as first part.
This will also work when building an image through build-args:
How Has This Been Tested?
Merge criteria: