Repository navigation
fix: reverting RHOAIENG-27721 e2e tests - #2199
openshift-merge-bot[bot] merged 1 commit into
Conversation
WalkthroughA set of end-to-end test files had their deletion recovery validation test cases commented out and disabled. This affects tests for deployment, configmap, service, serviceaccount, and RBAC deletion recovery across multiple components. Each disabled test is annotated with a TODO referencing ticket RHOAIENG-27721 for future hardening. Changes
Estimated code review effort2 (~15 minutes) Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/e2e/workbenches_test.go (1)
25-25: Remove redundant error check.Line 25 contains a redundant
require.NoError(t, err)statement. There's no preceding error assignment, and the same check already exists on line 19 afterNewComponentTestCtx.- require.NoError(t, err)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
tests/e2e/codeflare_test.go(1 hunks)tests/e2e/dashboard_test.go(1 hunks)tests/e2e/datasciencepipelines_test.go(1 hunks)tests/e2e/feastoperator_test.go(1 hunks)tests/e2e/kserve_test.go(1 hunks)tests/e2e/kueue_test.go(1 hunks)tests/e2e/llamastackoperator_test.go(1 hunks)tests/e2e/modelcontroller_test.go(1 hunks)tests/e2e/modelmeshserving_test.go(1 hunks)tests/e2e/modelregistry_test.go(1 hunks)tests/e2e/ray_test.go(1 hunks)tests/e2e/trainingoperator_test.go(1 hunks)tests/e2e/trustyai_test.go(1 hunks)tests/e2e/workbenches_test.go(1 hunks)
🔇 Additional comments (14)
tests/e2e/ray_test.go (1)
31-36: LGTM - Correctly disabling flaky deletion recovery tests.The deletion recovery tests are properly commented out with appropriate TODO referencing RHOAIENG-27721. This temporary measure aligns with the PR objectives to improve test stability until these tests can be hardened.
tests/e2e/modelmeshserving_test.go (1)
32-37: LGTM - Consistent implementation of test disabling.The deletion recovery tests are correctly commented out following the same pattern as other files in this PR. The TODO comment properly references RHOAIENG-27721 for future tracking.
tests/e2e/feastoperator_test.go (1)
31-36: LGTM - Properly disabling problematic tests.The changes correctly implement the temporary disabling of deletion recovery tests. The TODO comment provides clear context for future re-enablement once the tests are hardened.
tests/e2e/llamastackoperator_test.go (1)
31-36: LGTM - Consistent test disabling across components.The deletion recovery tests are appropriately commented out with proper TODO documentation. This maintains consistency with the broader pattern of temporarily disabling flaky tests across all component test suites.
tests/e2e/modelregistry_test.go (1)
43-48: LGTM - Complete revert implementation.The deletion recovery tests are correctly commented out following the established pattern. Despite this test suite having additional test cases, the disabling of the problematic deletion recovery tests is implemented consistently with all other component test files.
tests/e2e/trainingoperator_test.go (1)
31-36: LGTM - Appropriate temporary disabling of flaky tests.The commented-out deletion recovery tests align with the PR objectives to improve CI stability. The TODO comment with ticket reference (RHOAIENG-27721) ensures proper tracking for future hardening.
tests/e2e/workbenches_test.go (1)
33-38: LGTM - Consistent with the coordinated test disabling.The deletion recovery tests are appropriately commented out with proper tracking reference, matching the pattern across all affected test files.
tests/e2e/datasciencepipelines_test.go (1)
37-42: LGTM - Consistent test disabling pattern.The deletion recovery tests are properly commented out with tracking reference, maintaining consistency with the coordinated effort across all component test files.
tests/e2e/modelcontroller_test.go (1)
44-49: LGTM - Proper test disabling with tracking.The deletion recovery tests are consistently commented out with the same TODO reference (RHOAIENG-27721), following the established pattern for this coordinated revert.
tests/e2e/kserve_test.go (1)
85-90: LGTM - Consistent pattern across all test files.The deletion recovery tests are appropriately commented out with proper TODO tracking, completing the coordinated effort to disable these flaky tests across all component test suites.
tests/e2e/codeflare_test.go (1)
31-36: LGTM! Clean temporary disabling of flaky tests.The deletion recovery validation tests are properly commented out with consistent formatting and clear TODO tracking. This aligns with the PR objective to temporarily disable flaky tests until they can be hardened.
tests/e2e/dashboard_test.go (1)
45-51: LGTM! Consistent disabling of deletion recovery tests.The dashboard test suite correctly disables all deletion recovery validation tests, including the dashboard-specific route deletion recovery test. The formatting and TODO tracking are consistent with the coordinated effort across all test suites.
tests/e2e/trustyai_test.go (1)
44-49: LGTM! Consistent implementation of test disabling.The TrustyAI test suite follows the same pattern as other test suites, properly commenting out the deletion recovery validation tests with consistent formatting and tracking reference.
tests/e2e/kueue_test.go (1)
66-71: LGTM! Completes the coordinated test disabling effort.The Kueue test suite correctly implements the same deletion recovery test disabling pattern as all other test suites. This maintains consistency across the entire end-to-end testing framework and successfully achieves the PR objective of temporarily removing flaky tests.
|
/approve |
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2199 +/- ##
=======================================
Coverage 40.91% 40.91%
=======================================
Files 140 140
Lines 10999 10999
=======================================
Hits 4500 4500
Misses 6119 6119
Partials 380 380 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/lgtm |
|
@carlkyrillos: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ugiordan, zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Reverting the tests added in #2153 until they can be hardened. Right now we're seeing too many flaky failures with them
How Has This Been Tested?
Screenshot or short clip
Merge criteria
Summary by CodeRabbit