[StevenTobin]

This reverts commit 2e120d7.

Description

Revert #2174

How Has This Been Tested?

Screenshot or short clip

Merge criteria

• You have read the contributors guide.
• Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
• Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

• Tests
  • Added a comprehensive end-to-end test suite for the LlamaStackOperator component, covering scenarios such as enabling/disabling the component, verifying resource ownership, updating deployments, checking releases, and recovery from resource deletion.

[coderabbitai]

Walkthrough

A new end-to-end test suite for the LlamaStackOperator component has been introduced. The suite is registered within the existing component test group and includes multiple test cases covering the component's behavior, resource management, and recovery mechanisms. Supporting structures and functions were added to facilitate these tests.

Changes

File(s)	Change Summary
tests/e2e/controller_test.go	Registered llamastackOperatorTestSuite for the LlamaStackOperator component in the test group.
tests/e2e/llamastackoperator_test.go	Added new test suite, context struct, and test cases for LlamaStackOperator end-to-end testing.

Sequence Diagram(s)

sequenceDiagram
    participant TestRunner
    participant LlamaStackOperatorTestCtx
    participant KubernetesCluster

    TestRunner->>LlamaStackOperatorTestCtx: Initialize test context
    loop For each test case
        TestRunner->>LlamaStackOperatorTestCtx: Execute test case
        LlamaStackOperatorTestCtx->>KubernetesCluster: Validate/modify resources (deployments, configmaps, etc.)
        KubernetesCluster-->>LlamaStackOperatorTestCtx: Return resource state/result
        LlamaStackOperatorTestCtx-->>TestRunner: Report test outcome
    end

Loading

Possibly related PRs

• disable llama tests #2174: Removes the LlamaStackOperator component test suite and its registration, which is the direct inverse of this PR.

Suggested labels

lgtm, approved

Suggested reviewers

• zdtsw

Poem

In the meadow of tests where llamas play,
A new operator joins the fray.
End-to-end, we check and see,
That all is well in LlamaStack’s spree.
With clusters watched and resources neat,
This rabbit’s work is now complete! 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a1f0735 and 69b7cb0.

📒 Files selected for processing (2)

• tests/e2e/controller_test.go (1 hunks)
• tests/e2e/llamastackoperator_test.go (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (2)

tests/e2e/controller_test.go (1)

api/components/v1alpha1/llamastackoperator_types.go (1)

• LlamaStackOperatorComponentName (10-10)

tests/e2e/llamastackoperator_test.go (4)

tests/e2e/components_test.go (2)

• ComponentTestCtx (30-35)
• NewComponentTestCtx (44-62)

api/components/v1alpha1/llamastackoperator_types.go (1)

• LlamaStackOperator (32-38)

tests/e2e/controller_test.go (1)

• TestCase (101-104)

tests/e2e/helper_test.go (1)

• RunTestCases (73-88)

🔇 Additional comments (4)

tests/e2e/llamastackoperator_test.go (3)

1-9: LGTM: Clean package structure and imports

The package declaration and imports are properly structured. The imports include the necessary testing framework and component API dependencies.

---

11-13: LGTM: Proper test context structure

The LlamaStackOperatorTestCtx struct correctly embeds ComponentTestCtx, following the established pattern for component tests in this framework.

---

15-41: LGTM: Comprehensive test suite with proper structure

The test suite follows the established e2e testing patterns and includes comprehensive coverage:

• Component lifecycle: Enable/disable validation
• Resource management: Owner references, resource updates, releases
• Recovery testing: Deletion recovery for deployments, configmaps, services, service accounts, and RBAC

The test cases are well-organized and use the standard RunTestCases helper function for execution.

tests/e2e/controller_test.go (1)

127-127: LGTM: Proper test suite registration

The LlamaStackOperator test suite is correctly registered in the Components scenarios map, following the established pattern and maintaining alphabetical order with other component tests.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [zdtsw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zdtsw]

/test opendatahub-operator-e2e

at least it is not lls-o this time

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.73%. Comparing base (a1f0735) to head (69b7cb0).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2179   +/-   ##
=======================================
  Coverage   36.73%   36.73%           
=======================================
  Files          91       91           
  Lines        8107     8107           
=======================================
  Hits         2978     2978           
  Misses       4855     4855           
  Partials      274      274           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.