Skip to content

disable llama tests - #2174

Merged
StevenTobin merged 1 commit into
opendatahub-io:mainfrom
StevenTobin:disable_llamastack_tests_in_e2e
Jul 17, 2025
Merged

StevenTobin merged 1 commit into
opendatahub-io:mainfrom
StevenTobin:disable_llamastack_tests_in_e2e

Conversation

@StevenTobin

@StevenTobin StevenTobin commented Jul 17, 2025 •

Copy link
Copy Markdown
Contributor

Description

The llamastack e2e tests are currently failing. Remove them for now until the problem is fixed.

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

  • Tests
    • Removed all end-to-end tests for the LlamaStack operator component.
    • Disabled the LlamaStack operator component from the components test suite runs.

@coderabbitai

coderabbitai Bot commented Jul 17, 2025 •

Copy link
Copy Markdown
Contributor

Walkthrough

The changes remove the end-to-end test suite for the LlamaStack operator component by deleting its test file and eliminating its entry from the components test group in the main controller test file. No changes were made to other logic, error handling, or public declarations.

Changes

File(s) Change Summary
tests/e2e/llamastackoperator_test.go Deleted the entire test suite for the LlamaStack operator component.
tests/e2e/controller_test.go Removed the LlamaStack operator component from the components test group scenarios map.

Suggested labels

lgtm, approved

Suggested reviewers

  • valdar
  • mlassak

Poem

The LlamaStack tests have hopped away,
No more checks for them today.
With files removed and code made neat,
The test suite’s lighter on its feet.
🐇✨
Onward we bound, with tests trimmed down,
In code’s green fields, no llamas found!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b635999 and 2e120d7.

📒 Files selected for processing (2)
  • tests/e2e/controller_test.go (0 hunks)
  • tests/e2e/llamastackoperator_test.go (0 hunks)
💤 Files with no reviewable changes (2)
  • tests/e2e/llamastackoperator_test.go
  • tests/e2e/controller_test.go
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@openshift-ci
openshift-ci Bot requested review from asanzgom and lphiri July 17, 2025 09:12
@openshift-ci

openshift-ci Bot commented Jul 17, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@StevenTobin

Copy link
Copy Markdown
Contributor Author

/hold

@StevenTobin

Copy link
Copy Markdown
Contributor Author

/unhold

@StevenTobin
StevenTobin merged commit 2b7daee into opendatahub-io:main Jul 17, 2025
@github-project-automation github-project-automation Bot moved this from Todo to Done in ODH Platform Planning Jul 17, 2025
@StevenTobin StevenTobin mentioned this pull request Jul 17, 2025
5 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Jul 21, 2025
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants