Use full test suite on make test

[cyphar]

Enable the full test suite to run on make test. They also all run
inside a Docker container for maximum reproducibility.

Signed-off-by: Aleksa Sarai [email protected]

[hqhq]

I don't think snifftest is needed anymore, it's all covered by integration test, so I tried to remove it in #785 WDYT?

[cyphar]

I'll respond in the issue.

[hqhq]

LGTM

[mlaventure]

Would it be possible to always run this in TAP mode via -t while at it? Jenkins doesn't log very nicely the output otherwise.

[cyphar]

@mlaventure I've updated it to use -t mode. As much as I love unicode checkmarks, Jenkins doesn't.

[mlaventure]

@cyphar Thanks, output is a lot more readable now!

[cyphar]

Are you okay with this @mrunalp @crosbymichael ?

[crosbymichael]

i got this when running locally after the unit test run

PASS
ok      _/go/src/github.com/opencontainers/runc/libcontainer/xattr      0.004s
Makefile:56: recipe for target 'localunittest' failed
make[1]: *** [localunittest] Error 1
make[1]: Leaving directory '/go/src/github.com/opencontainers/runc'
Makefile:50: recipe for target 'localtest' failed
make: *** [localtest] Error 2
Makefile:53: recipe for target 'unittest' failed
make[1]: *** [unittest] Error 2
make[1]: Leaving directory '/home/michael/development/gocode/src/github.com/opencontainers/runc'
Makefile:47: recipe for target 'test' failed
make: *** [test] Error 2

[cyphar]

@crosbymichael Are you running the tests as root? Also, there doesn't appear to be an error message in your output.

[crosbymichael]

@cyphar i thought it was supposed to run them in the container now so i'm just running make test as my normal user

[cyphar]

Ah, I see now that you were running make test (the error trace is hard to read in make)? I thought you meant "locally" as in make localtest (which requires root). I can't seem to reproduce that locally on this branch.

[crosbymichael]

LGTM