Remove sniffTest #785
Merged
Remove sniffTest #785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have integration test now, not ideal though, but it surely can replace sniffTest. Signed-off-by: Qiang Huang <[email protected]>
Member
I don't really have a strong opinion, but it does appear redundant to have a sniff test that is then replicated in an integration test. /cc @duglin -- do you have any reason why we should keep it in? In #554 you mention that the sniff tests were just meant to be a stopgap until we had a proper testing framework -- I think bats qualifies. |
|
I agree and if there is some tests in sniff that's missing from integration then we should add it. |
Member
|
In that case, LGTM. |
Contributor
|
LGTM |
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
schema: Add 'test' target to the Makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have integration test now, not ideal though, but it
surely can replace sniffTest.
Signed-off-by: Qiang Huang [email protected]