Skip to content

[1.3] ci: add go 1.26#5181

Merged
kolyshkin merged 1 commit intoopencontainers:release-1.3from
kolyshkin:1.3-go126
Mar 17, 2026
Merged

[1.3] ci: add go 1.26#5181
kolyshkin merged 1 commit intoopencontainers:release-1.3from
kolyshkin:1.3-go126

Conversation

@kolyshkin
Copy link
Copy Markdown
Contributor

Same as commit b9e3eec in release-1.4 branch.

Same as commit b9e3eec in release-1.4 branch.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin added this to the 1.3.5 milestone Mar 16, 2026
@kolyshkin kolyshkin mentioned this pull request Mar 16, 2026
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +44 to +45
- race: -race
go-version: 1.25.x
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh; should this be 1.26.x then? (to match the comment) or do we want to test "stable version we use to build"?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I asked the same thing in another PR, I can't find where now :-D

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are exclusions.

So yes, we only do -race with latest stable version (1.26.x) and we exclude 1.25.x.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! I think I left the exact same comment on another PR 🙈🙈🙈😆😆😆

Copy link
Copy Markdown
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin kolyshkin merged commit c5f4a41 into opencontainers:release-1.3 Mar 17, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants