Merged
Conversation
Contributor
Author
|
@opencontainers/runc-maintainers PTAL (and please help with the quote). |
Contributor
Author
|
Hmm, I think we need Go 1.26 fix, too. |
Contributor
Author
No, we don't (this was only needed because we're running exec twice due to CLONE_INTO_CGROUP, which we're not doing in 1.3.x). Yet it makes sense to add Go 1.26 into CI. Opened #5181 |
AkihiroSuda
approved these changes
Mar 17, 2026
cyphar
approved these changes
Mar 17, 2026
Member
cyphar
left a comment
There was a problem hiding this comment.
LGTM, feel free to include the 1.26 CI PR or not.
Member
|
Probably would be good to verify; packagers may be building with latest go version, so having some early warning in CI to see if anything fails never hurts? |
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to release 1.3.5, mostly for the fix for the
cannot start a container that has stoppederror (#5151).Copy-paste from the CHANGELOG (yes I still need a quote).
[1.3.5] - 2026-03-17
Fixed
properly. ([1.3] libct/specconv: fix partial clear of atime mount flags #5115, libct/specconv: always clear entire MOUNT_ATTR__ATIME field when updating atime mode #5098)
cannot start a container that has stoppederrors whenrunning
runc createand has thus been reverted. ([1.3] Revert "Preventing containers from being unable to be deleted" #5158,Revert "Preventing containers from being unable to be deleted" #5153, "cannot start a container that has stopped" in F-43 #5151, Add creating status to ensure state.json exists when runc kill. #4645, Preventing containers from being unable to be deleted #4757)
Changed