Skip to content

[1.3] ci: add go 1.26 #5181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kolyshkin merged 1 commit into from
Mar 17, 2026
Merged

[1.3] ci: add go 1.26 #5181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-24.04, ubuntu-24.04-arm]
go-version: [1.23.x, 1.25.x]
go-version: [1.23.x, 1.25.x, 1.26.x]
rootless: ["rootless", ""]
race: ["-race", ""]
criu: ["", "criu-dev"]
Expand All @@ -34,11 +34,15 @@ jobs:
# (need to compile criu) and don't add much value/coverage.
- criu: criu-dev
go-version: 1.23.x
- criu: criu-dev
go-version: 1.25.x
- criu: criu-dev
rootless: rootless
# Do race detection only on latest Go.
# Do race detection only with latest stable Go version.
- race: -race
go-version: 1.23.x
- race: -race
go-version: 1.25.x
Comment on lines +44 to +45
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh; should this be 1.26.x then? (to match the comment) or do we want to test "stable version we use to build"?

Copy link
Copy Markdown
Member

@rata rata Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I asked the same thing in another PR, I can't find where now :-D

Copy link
Copy Markdown
Contributor Author

@kolyshkin kolyshkin Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are exclusions.

So yes, we only do -race with latest stable version (1.26.x) and we exclude 1.25.x.

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! I think I left the exact same comment on another PR 🙈🙈🙈😆😆😆


runs-on: ${{ matrix.os }}

Expand Down
Loading