Skip to content

CHANGELOG fixups#5185

Merged
kolyshkin merged 2 commits intoopencontainers:mainfrom
kolyshkin:fix-5172
Mar 21, 2026
Merged

CHANGELOG fixups#5185
kolyshkin merged 2 commits intoopencontainers:mainfrom
kolyshkin:fix-5172

Conversation

@kolyshkin
Copy link
Copy Markdown
Contributor

  1. fix entry placement

    Commit 0079bee (PR Support specs.LinuxSeccompFlagWaitKillableRecv #5172) incorrectly placed an entry into v1.4.1 changelog.
    Move it to under "Unreleased".

  2. forward-port v1.3.5 changes

    From commit 488fc13 (PR Release 1.3.5 #5180).

Copy link
Copy Markdown
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Commit 0079bee incorrectly placed an entry into v1.4.1 changelog.
Move it to under "Unreleased".

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
From commit 488fc13.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin
Copy link
Copy Markdown
Contributor Author

Another reason to have changelog entries in separate files (as discussed in #5172 (comment)) is to avoid manual rebases due to conflicts in CHANGELOG.md. Assuming every PR will have a changelog entry, we'll have lots of such conflicts.

@kolyshkin
Copy link
Copy Markdown
Contributor Author

Also I just realized that we're patching CHANGELOG twice when doing backports (in the original PR, and in the backport PR), but ideally the change should only be listed once.

@kolyshkin kolyshkin merged commit dc2558d into opencontainers:main Mar 21, 2026
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants