Fixes for osc-1.x

[dmach]

These fixes will be needed when we distribute osc-1.x instead of the current 0.x.
Also, it might be good to test integration with openSUSE/osc's master more frequently and report any issues found.

[coolo]

Our testing is supposed to happen on openSUSE:Tools, but it seems the container fails to build for a bit:
https://build.opensuse.org/package/live_build_log/openSUSE:Tools:Images/osrt-testenv-tumbleweed/containers_tumbleweed/x86_64

[dmach]

Our testing is supposed to happen on openSUSE:Tools

That if usually too late.
We make a new osc release, submit a request to openSUSE:Tools when the request gets accepted, it is usually forwarded to Factory. Testing on OBS:Server:Unstable (which contains osc built from git master) would help us to catch issues earlier.

[coolo]

But that's clearly out of scope of this repo - and as you can see I even fail to monitor one container building, leave alone two.

[codecov-commenter]

Codecov Report

Base: 28.48% // Head: 13.91% // Decreases project coverage by -14.56% ⚠️

Coverage data is based on head (f32c097) compared to base (21411e5).
Patch coverage: 11.62% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #2879       +/-   ##
===========================================
- Coverage   28.48%   13.91%   -14.57%     
===========================================
  Files          84       84               
  Lines       14447    14471       +24     
===========================================
- Hits         4115     2014     -2101     
- Misses      10332    12457     +2125     

Impacted Files	Coverage Δ
osclib/pkglistgen_comments.py	0.00% <0.00%> (-16.88%)	⬇️
pkglistgen/cli.py	0.00% <0.00%> (ø)
pkglistgen/tool.py	0.00% <0.00%> (ø)
check_source.py	70.61% <100.00%> (-0.58%)	⬇️
osclib/core.py	32.39% <100.00%> (-25.97%)	⬇️
osclib/stagingapi.py	55.85% <100.00%> (-3.15%)	⬇️
osclib/obslock.py	0.00% <0.00%> (-92.11%)	⬇️
check_bugowner.py	0.00% <0.00%> (-87.10%)	⬇️
origin-manager.py	0.00% <0.00%> (-86.54%)	⬇️
osclib/origin.py	0.00% <0.00%> (-73.89%)	⬇️
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[coolo]

The failing comment_tests leads me to believe that your change in oscParse is not working with the osc we have.

[coolo]

confirmed. if I readd the line, it works again in local tests

[dirkmueller]

@dmach are you planning to work on this? Many osc 1.x.fixes have been merged already. Not sure if there's still something that needs to be done?

[dmach]

@dmach are you planning to work on this? Many osc 1.x.fixes have been merged already. Not sure if there's still something that needs to be done?

@dirkmueller I'm not sure, to be honest. Probably not.
If the current code works with osc 1.x, then this pull request may not be needed any more.

@SchoolGuy you've pushed many commits to this PR - how about you, do you want them in or is it something that got to the code in different pull requests already?

[DimStar77]

There is at least #2928 reported to fail with osc 1.x

[SchoolGuy]

The commits that are part of this PR are cherry picked. For example #2877 is part of this PR. I believe that after a rebase all of my commits should be gone. If not I would be confused and would need to look deeper @dmach ...