Fixes for osc-1.x #2918
Fixes for osc-1.x #2918
Conversation
Codecov ReportBase: 28.51% // Head: 28.45% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2918 +/- ##
==========================================
- Coverage 28.51% 28.45% -0.06%
==========================================
Files 84 84
Lines 14472 14507 +35
==========================================
+ Hits 4126 4128 +2
- Misses 10346 10379 +33
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dirkmueller
force-pushed
the
osc1x
branch
2 times, most recently
from
2f90b1f
to
b2d1c38
Compare
| @@ -72,7 +74,7 @@ def _check_requests(self, project, package, rev): | |||
| project = project[len(prefix):] | |||
| sr = srprefix | |||
| break | |||
| requests = osc.core.get_request_list(apiurl, project, package, None, ['new', 'review'], 'submit') | |||
| requests = get_request_list_with_history(apiurl, project, package, None, ['new', 'review'], 'submit') | |||
There was a problem hiding this comment.
This didn't use withfullhistory, so it should behave the same with the compatibility wrapper. Were you able to find the cause of the difference?
There was a problem hiding this comment.
Yes, the return values are different. I can search the details tomorrow. for now I'd like to get this in to have a green CI to iterate on improving the quality on this.
| @@ -56,10 +56,52 @@ def groups_members(apiurl, groups): | |||
|
|
|||
| return members | |||
|
|
|||
| # osc uses xml.etree while we rely on lxml | |||
|
|
|||
| def get_request_list_with_history( | |||
There was a problem hiding this comment.
Can you add a deprecation warning or at least a # TODO comment?
There was a problem hiding this comment.
there's one on the line below (63). I can make it a deprecation warning when everything else is green.
There was a problem hiding this comment.
AFAIK a warning wouldn't make it less green than it was previously, wouldn't it?
There was a problem hiding this comment.
It does not. just want to get to see that everything works before adding further code changes (that would restart the CI). do want to leave from work today at some point soon ;)
There was a problem hiding this comment.
Ah, so it's just about the push, I see. In that case we'll need a separate PR anyway.
do want to leave from work today at some point soon ;)
Protip: You can do that while the CI is running - /me writes this reply from home 😛
Starting with the minimal changes from #2879 again