-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typing hints #2877
Add typing hints #2877
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please either avoid the complex types or make them proper class
Codecov ReportBase: 28.49% // Head: 28.50% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2877 +/- ##
==========================================
+ Coverage 28.49% 28.50% +0.01%
==========================================
Files 84 84
Lines 14442 14467 +25
==========================================
+ Hits 4115 4124 +9
- Misses 10327 10343 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This PR does two things: