Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing hints #2877

Merged
merged 4 commits into from
Oct 13, 2022
Merged

Add typing hints #2877

merged 4 commits into from
Oct 13, 2022

Conversation

SchoolGuy
Copy link
Contributor

This PR does two things:

  • Add typing hints and docstrings to some of the functionality of this repository
  • Fix typos in the documentation

Copy link
Member

@coolo coolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please either avoid the complex types or make them proper class

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022

Codecov Report

Base: 28.49% // Head: 28.50% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (3a20df6) compared to base (aad2291).
Patch coverage: 49.36% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2877      +/-   ##
==========================================
+ Coverage   28.49%   28.50%   +0.01%     
==========================================
  Files          84       84              
  Lines       14442    14467      +25     
==========================================
+ Hits         4115     4124       +9     
- Misses      10327    10343      +16     
Impacted Files Coverage Δ
pkglistgen/cli.py 0.00% <0.00%> (ø)
pkglistgen/tool.py 0.00% <0.00%> (ø)
osclib/pkglistgen_comments.py 18.50% <47.69%> (+1.62%) ⬆️
osclib/core.py 58.41% <100.00%> (+0.05%) ⬆️
osclib/stagingapi.py 59.04% <100.00%> (-0.34%) ⬇️
osclib/accept_command.py 73.51% <0.00%> (+0.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SchoolGuy SchoolGuy requested a review from coolo October 13, 2022 12:10
@SchoolGuy SchoolGuy requested a review from coolo October 13, 2022 12:14
@SchoolGuy SchoolGuy requested a review from coolo October 13, 2022 12:48
@coolo coolo merged commit 5e2a171 into openSUSE:master Oct 13, 2022
@SchoolGuy SchoolGuy deleted the add_typing_hints branch October 13, 2022 13:04
@SchoolGuy SchoolGuy mentioned this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants