Merged
Conversation
rockbmb
force-pushed
the
staking-e2e-tests
branch
from
e441075 to
4473da1
Compare
This happened in the Kusama network, due to the commission for validators having been set considering only Polkadot, where the minimum is 0, whereas in Kusama it is not.
Now that staking tests correctly use the network's correct minimum validator commission, the Kusama staking lifecycle test's snapshots must be updated
rockbmb
force-pushed
the
staking-e2e-tests
branch
from
d89232d to
ae712e5
Compare
xlc
approved these changes
Feb 12, 2025
| await relayClient.dev.newBlock() | ||
|
|
||
| // Because this extrinsic was executed via the scheduler technique, its events won't be available | ||
| // through `checkEvents` - hence the need for this event extraction process. |
Member
There was a problem hiding this comment.
there is checkSystemEvents can be used
Collaborator
Author
There was a problem hiding this comment.
I will correct this, and push a fix posthaste.
Collaborator
Author
There was a problem hiding this comment.
On closer inspection, checkSystemEvents here would help in knowing that the manual scheduler injection succeeded, but it still wouldn't allow us to check nominationPool events (that the extrinsic in question doesn't emit yet, but the previous holds without loss of generality).
However, I see now that there are a few places where checkSystemEvents would be helpful - it can be done in a follow-up PR.
github-merge-queue bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Feb 14, 2025
# Description open-web3-stack/polkadot-ecosystem-tests#174 showed the test for the `pallet_staking::chill_other` extrinsic could be more exhaustive. This PR adds those checks, and also a few more to another test related to `chill_other`, `pallet_staking::tests::change_of_absolute_max_nominations`. ## Integration N/A ## Review Notes N/A --------- Co-authored-by: Bastian Köcher <git@kchr.de>
github-merge-queue bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Feb 14, 2025
# Description open-web3-stack/polkadot-ecosystem-tests#174 showed the test for the `pallet_staking::chill_other` extrinsic could be more exhaustive. This PR adds those checks, and also a few more to another test related to `chill_other`, `pallet_staking::tests::change_of_absolute_max_nominations`. ## Integration N/A ## Review Notes N/A --------- Co-authored-by: Bastian Köcher <git@kchr.de>
clangenb
pushed a commit
to clangenb/polkadot-sdk
that referenced
this pull request
Feb 19, 2025
# Description open-web3-stack/polkadot-ecosystem-tests#174 showed the test for the `pallet_staking::chill_other` extrinsic could be more exhaustive. This PR adds those checks, and also a few more to another test related to `chill_other`, `pallet_staking::tests::change_of_absolute_max_nominations`. ## Integration N/A ## Review Notes N/A --------- Co-authored-by: Bastian Köcher <git@kchr.de>
This was referenced Mar 3, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just like #115, #165, this adds E2E tests to staking.
The data that are generated here instead of using what may exist on-chain (e.g. validators) is for the following reason: AHM tests will at times be run on a freshly generated chain spec that may have empty storage for all its pallets - thus no assumptions should be made regarding on-chain data.