Add minor improvements to chill_other test#7553
Merged
Conversation
There was a missing switch in a `set_staking_configs` call, which wasn't quite testing the right thing
rockbmb
added
T2-pallets
lexnv
reviewed
Feb 13, 2025
prdoc/pr_7553.prdoc
Outdated
| # Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0 | ||
| # See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json | ||
|
|
||
| title: Add more checks to `chill_other` tests |
Contributor
There was a problem hiding this comment.
nit: An alternative would be t0-silent for tests, however I like the PR doc description 🙏
Contributor
Author
There was a problem hiding this comment.
By t0-silent, you are referring to a PR tag on GitHub, correct?
lexnv
approved these changes
Feb 13, 2025
bkchr
approved these changes
Feb 14, 2025
bkchr
added
R0-no-crate-publish-required
auto-merge was automatically disabled
February 14, 2025 18:49
Pull Request is not mergeable
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
clangenb
pushed a commit
to clangenb/polkadot-sdk
that referenced
this pull request
Feb 19, 2025
# Description open-web3-stack/polkadot-ecosystem-tests#174 showed the test for the `pallet_staking::chill_other` extrinsic could be more exhaustive. This PR adds those checks, and also a few more to another test related to `chill_other`, `pallet_staking::tests::change_of_absolute_max_nominations`. ## Integration N/A ## Review Notes N/A --------- Co-authored-by: Bastian Köcher <git@kchr.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
open-web3-stack/polkadot-ecosystem-tests#174 showed the test for the
pallet_staking::chill_otherextrinsic could be more exhaustive.This PR adds those checks, and also a few more to another test related to
chill_other,pallet_staking::tests::change_of_absolute_max_nominations.Integration
N/A
Review Notes
N/A