[chore] Remove duplicate check target#2490
Merged
lmolkova merged 1 commit intoopen-telemetry:mainfrom Jul 8, 2025
Merged
Conversation
This PR removes a `check` target that I added without realizing that there already was a target called `check`. The original intention was to add a target that could be run locally without `markdown-link-check` as that used to take a considerably long time. Since that is a fair bit quicker now, there isn't much reason for it anymore. This PR essentially undoes what I did when I added the check.
trentm
approved these changes
Jul 7, 2025
Contributor
|
See related #2486 (comment) regarding the markdown-link-check failure. |
Contributor
#2494 to fix this. |
lmolkova
approved these changes
Jul 8, 2025
github-project-automation
Bot
moved this from Untriaged
to Needs More Approval
in Semantic Conventions Triage
Merged
via the queue into
open-telemetry:main
with commit Jul 8, 2025
2ba21a8
17 of 22 checks passed
spurplewang
pushed a commit
to spurplewang/semantic-conventions
that referenced
this pull request
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2481
Changes
This PR removes a
checktarget that I added without realizing that there already was a target calledcheck. The original intention was to add a target that could be run locally withoutmarkdown-link-checkas that used to take a considerably long time. Since that is a fair bit quicker now, there isn't much reason for it anymore. This PR essentially undoes what I did when I added the check.Merge requirement checklist
[chore]