Fix value of deprecated 'az.ai.openai' enum back to 'az.ai.openai'#2486
Fix value of deprecated 'az.ai.openai' enum back to 'az.ai.openai'#2486trentm wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
I believe there was a small error in open-telemetry#1698. When 'az.ai.openai' was deprecated, its 'value' should not have changed: https://github.com/open-telemetry/semantic-conventions/pull/1698/files#diff-0936f2641601c5b370b10dfb33c8f82d6d731a2663cf042eef2aa5114c720902R71
|
I used |
|
The (FWIW running I guess I cannot write long changelog entries? I guess I can try subtext. |
|
The markdown-link-check failure: That site doesn't load for me at all. I guess it is down. |
Notes: - There was intentionally *not* a release for v1.35.0 because it included a bug that was found soon after release. - There is an outstanding semconv issue regarding the deprecated `az.ai.openai` enum value. open-telemetry/semantic-conventions#2486
#2494 to fix this. |
|
IIUC, this change is no longer necessary. This small change was handled as part of the bigger #2046 which made this correction while also deprecating |
I believe there was a small error in #1698. When 'az.ai.openai' was
deprecated, its 'value' should not have changed:
https://github.com/open-telemetry/semantic-conventions/pull/1698/files#diff-0936f2641601c5b370b10dfb33c8f82d6d731a2663cf042eef2aa5114c720902R71
Aside, I noticed this when generating the changelog for the JS semconv package for v1.36.0. The generated changelog included:
This stuck out as odd (the JS constant identifier doesn't match the new value).