Skip to content

[chore] Remove duplicate check target #2490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmolkova merged 1 commit into from
Jul 8, 2025
Merged

[chore] Remove duplicate check target #2490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,6 @@ WEAVER_CONTAINER=$(WEAVER_CONTAINER_REPOSITORY)/$(VERSIONED_WEAVER_CONTAINER_NO_
OPA_CONTAINER=$(OPA_CONTAINER_REPOSITORY)/$(VERSIONED_OPA_CONTAINER_NO_REPO)
LYCHEE_CONTAINER=$(LYCHEE_CONTAINER_REPOSITORY)/$(VERSIONED_LYCHEE_CONTAINER_NO_REPO)

CHECK_TARGETS=install-tools markdownlint misspell table-check \
schema-check check-file-and-folder-names-in-docs

# Determine if "docker" is actually podman
DOCKER_VERSION_OUTPUT := $(shell docker --version 2>&1)
DOCKER_IS_PODMAN := $(shell echo $(DOCKER_VERSION_OUTPUT) | grep -c podman)
Expand Down Expand Up @@ -88,10 +85,7 @@ endif

# TODO: add `yamllint` step to `all` after making sure it works on Mac.
.PHONY: all
all: $(CHECK_TARGETS) markdown-link-check

.PHONY: check
check: $(CHECK_TARGETS)
all: install-tools markdownlint misspell table-check schema-check check-file-and-folder-names-in-docs markdown-link-check

.PHONY: check-file-and-folder-names-in-docs
check-file-and-folder-names-in-docs:
Expand Down Expand Up @@ -348,4 +342,4 @@ check-dead-yaml:
--config=/home/weaver/templates/registry/signal-groups-weaver.yaml \
. \
/home/weaver/target
$(TOOLS_DIR)/scripts/find-dead-yaml.sh $(PWD)/internal/tools/bin/signal-groups.txt $(PWD)/docs
$(TOOLS_DIR)/scripts/find-dead-yaml.sh $(PWD)/internal/tools/bin/signal-groups.txt $(PWD)/docs
Loading