Skip to content

feat: Add event name to missing otel_error logs#1978

Merged
jmacd merged 2 commits intoopen-telemetry:mainfrom
andborja:andborja/MsgToErrorMacro
Feb 10, 2026
Merged

feat: Add event name to missing otel_error logs#1978
jmacd merged 2 commits intoopen-telemetry:mainfrom
andborja:andborja/MsgToErrorMacro

Conversation

@andborja
Copy link
Copy Markdown
Contributor

@andborja andborja commented Feb 6, 2026

Change Summary

Add eventName to missing logs.

What issue does this PR close?

Part of #1972

  • Closes #N/A

How are these changes tested?

local builds and tests

Are there any user-facing changes?

No

@andborja andborja requested a review from a team as a code owner February 6, 2026 00:48
@github-actions github-actions Bot added the rust Pull requests that update Rust code label Feb 6, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.23%. Comparing base (5cdec9c) to head (76d657f).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1978      +/-   ##
==========================================
- Coverage   86.23%   86.23%   -0.01%     
==========================================
  Files         525      525              
  Lines      164810   164810              
==========================================
- Hits       142127   142120       -7     
- Misses      22149    22156       +7     
  Partials      534      534              
Components Coverage Δ
otap-dataflow 88.22% <0.00%> (-0.01%) ⬇️
query_abstraction 80.61% <ø> (ø)
query_engine 90.23% <ø> (ø)
syslog_cef_receivers ∅ <ø> (∅)
otel-arrow-go 53.50% <ø> (ø)
quiver 92.15% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@afborja
Copy link
Copy Markdown

afborja commented Feb 9, 2026

Please don't merge it yet. I'll update it with the latest style (message as attribute)

@cijothomas
Copy link
Copy Markdown
Member

#1985 has fixed the issue with missing user friendly message. Do we need to continue with this PR (and #1977)

Apologies If I an missing something!

@andborja andborja force-pushed the andborja/MsgToErrorMacro branch from 6010a87 to 7babea5 Compare February 10, 2026 01:50
@andborja andborja changed the title feat: Add message parameter to otel_error macro feat: Add event name to missing otel_error logs Feb 10, 2026
@andborja
Copy link
Copy Markdown
Contributor Author

Please don't merge it yet. I'll update it with the latest style (message as attribute)

Updated with the latest format. You can merge it now. Thanks!

@jmacd jmacd added this pull request to the merge queue Feb 10, 2026
Merged via the queue into open-telemetry:main with commit 8ae3f08 Feb 10, 2026
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants