Skip to content

feat: Add message parameter to otel_warn macro#1977

Merged
jmacd merged 6 commits intoopen-telemetry:mainfrom
andborja:andborja/MsgToWarnMacro
Feb 10, 2026
Merged

feat: Add message parameter to otel_warn macro#1977
jmacd merged 6 commits intoopen-telemetry:mainfrom
andborja:andborja/MsgToWarnMacro

Conversation

@andborja
Copy link
Copy Markdown
Contributor

@andborja andborja commented Feb 6, 2026

Change Summary

Add event name to missing otel_warn! calls.

What issue does this PR close?

Part of #1972

  • Closes #NA

How are these changes tested?

local builds and tests

Are there any user-facing changes?

No

@andborja andborja requested a review from a team as a code owner February 6, 2026 00:18
@github-actions github-actions Bot added the rust Pull requests that update Rust code label Feb 6, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 32.00000% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.23%. Comparing base (e171021) to head (5bc23c7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1977      +/-   ##
==========================================
- Coverage   86.23%   86.23%   -0.01%     
==========================================
  Files         525      525              
  Lines      164808   164809       +1     
==========================================
- Hits       142121   142120       -1     
- Misses      22153    22155       +2     
  Partials      534      534              
Components Coverage Δ
otap-dataflow 88.22% <32.00%> (-0.01%) ⬇️
query_abstraction 80.61% <ø> (ø)
query_engine 90.23% <ø> (ø)
syslog_cef_receivers ∅ <ø> (∅)
otel-arrow-go 53.50% <ø> (ø)
quiver 92.15% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread rust/otap-dataflow/crates/telemetry/src/internal_events.rs
Comment thread rust/otap-dataflow/crates/controller/src/lib.rs
@andborja andborja force-pushed the andborja/MsgToWarnMacro branch from 808be65 to 1aa84aa Compare February 9, 2026 19:42
Copy link
Copy Markdown
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely glad to see this consistency. Thanks @andborja

Comment thread rust/otap-dataflow/crates/otap/src/tls_utils.rs Outdated
@jmacd jmacd enabled auto-merge February 10, 2026 01:03
@jmacd jmacd added this pull request to the merge queue Feb 10, 2026
Merged via the queue into open-telemetry:main with commit 65bc572 Feb 10, 2026
60 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants