Remove duplicate hostname attribute #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes open-telemetry#787 Idea from the issue is that we should use `host.name` with either of the proposed values. Signed-off-by: Bogdan Drutu <[email protected]>
arminru
reviewed
Aug 20, 2020
Oberon00
approved these changes
Aug 20, 2020
carlosalberto
approved these changes
Aug 20, 2020
tigrannajaryan
approved these changes
Aug 20, 2020
Co-authored-by: Armin Ruech <[email protected]>
tigrannajaryan
added
the
area:semantic-conventions
|
Uncontroversial and has enough reviews, merging. |
This was referenced Oct 7, 2020
This was referenced Oct 8, 2020
dmitryax
added a commit
to dmitryax/opentelemetry-specification
that referenced
this pull request
Sep 19, 2021
"host.namespace" was removed removed from unified model open-telemetry#838. We want to use "host.name" attribute to Splunk HEC "host" field instead.
dmitryax
added a commit
to dmitryax/opentelemetry-specification
that referenced
this pull request
Sep 19, 2021
`host.hostname` attributed was removed from unified model open-telemetry#838. We want to use `host.name` attribute to represent Splunk HEC "host" field instead.
This was referenced Jan 13, 2023
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #787
Idea from the issue is that we should use
host.namewith either of the proposed values.