chore!: remove duplicate hostname resource attribute #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwear
requested review from
dazuma,
ericmustin,
fbogsany and
robertlaurin
as code owners
fbogsany
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this in JS, so I thought I'd fix it here also. There were two host name attributes:
host.nameandhost.hostname. This PR removes the latter as per: open-telemetry/opentelemetry-specification#838. The spec is pretty loose about the precedence to use when determining thehost.namevalue. I chose the sequence: environment variable, gcp metadata hostname, Socket.gethostname. We can change that if there's a better ordering.