Provide clear guidance on what semconv actually enforces #3225

jsuereth · 2023-02-17T14:57:32Z

Fixes #2864
Fixes #2883

Changes

Explicitly define what is "enforced" by stability guarantees from Semantic conventions.
- We enforce attribute key names + types, across resource, span, metric and log
- We enforce span names
- We enforce metric names, units
Expand allowed changes to semconv to include metric attributes that do not increase timeseries count for a given metric.

Context

Sig discussion thread/doc here.

…by semconv that can be included in stability.

specification/versioning-and-stability.md

Co-authored-by: Trask Stalnaker <[email protected]>

specification/versioning-and-stability.md

Co-authored-by: Johannes Tax <[email protected]>

specification/versioning-and-stability.md

tigrannajaryan

Thanks for tackling this @jsuereth
I think it is important to define precisely what we guarantee.

specification/versioning-and-stability.md

Co-authored-by: Tigran Najaryan <[email protected]>

Co-authored-by: Carlos Alberto Cortez <[email protected]>

…`faas.max_memory` (open-telemetry#3209)

* Add connect_rpc to rpc.yaml * Add connect rpc into rpc-metrics and rpc markdown * Add Connect RPC change to CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Armin Ruech <[email protected]>

Co-authored-by: Yuri Shkuro <[email protected]>

Co-authored-by: Trask Stalnaker <[email protected]>

specification/versioning-and-stability.md

Co-authored-by: jack-berg <[email protected]>

lmolkova

I have no objection to additions done in the PR, but I still have concern wrt schema transformation and how/if it can really guarantee stability and work along with this PR.

I created #3296 and suggest that we keep schema transformations experimental with possibility to stabilize it in the future independently of current efforts to stabilize HTTP semconv.

specification/versioning-and-stability.md

Co-authored-by: Liudmila Molkova <[email protected]>

specification/versioning-and-stability.md

…try#3225) Fixes open-telemetry#2864 Fixes open-telemetry#2883 ## Changes - Explicitly define what is "enforced" by stability guarantees from Semantic conventions. - We enforce attribute key names + types, across resource, span, metric and log - We enforce span names - We enforce metric names, units - Expand allowed changes to semconv to include metric attributes that do not increase timeseries count for a given metric. ## Context Sig discussion thread/doc [here](https://docs.google.com/document/d/1Nvcf1wio7nDUVcrXxVUN_f8MNmcs0OzVAZLvlth1lYY/edit?usp=sharing). --------- Co-authored-by: Trask Stalnaker <[email protected]> Co-authored-by: Johannes Tax <[email protected]> Co-authored-by: Tigran Najaryan <[email protected]> Co-authored-by: Patrice Chalin <[email protected]> Co-authored-by: Sergey Kanzhelev <[email protected]> Co-authored-by: Carlos Alberto Cortez <[email protected]> Co-authored-by: Tyler Benson <[email protected]> Co-authored-by: Joshua Carpeggiani <[email protected]> Co-authored-by: Armin Ruech <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Co-authored-by: Asaf Mesika <[email protected]> Co-authored-by: Evan Mattson <[email protected]> Co-authored-by: jack-berg <[email protected]> Co-authored-by: Antoine Toulme <[email protected]> Co-authored-by: Christian Neumüller <[email protected]> Co-authored-by: Liudmila Molkova <[email protected]> Co-authored-by: Reiley Yang <[email protected]> Co-authored-by: Joshua MacDonald <[email protected]>

Fix open-telemetry#2864 with more clear guidance on what is enforced …

f037c83

…by semconv that can be included in stability.

jsuereth requested review from a team February 17, 2023 14:57

github-actions bot assigned jmacd Feb 17, 2023

trask reviewed Feb 17, 2023

View reviewed changes

specification/versioning-and-stability.md Outdated Show resolved Hide resolved

specification/versioning-and-stability.md Outdated Show resolved Hide resolved

jsuereth and others added 2 commits February 17, 2023 12:28

Update specification/versioning-and-stability.md

f1890e8

Co-authored-by: Trask Stalnaker <[email protected]>

Update specification/versioning-and-stability.md

a4f8505

Co-authored-by: Trask Stalnaker <[email protected]>

pyohannes reviewed Feb 17, 2023

View reviewed changes

specification/versioning-and-stability.md Show resolved Hide resolved

trask mentioned this pull request Feb 17, 2023

HTTP semcomv depends on other experimental docs #3219

Closed

pyohannes reviewed Feb 17, 2023

View reviewed changes

specification/versioning-and-stability.md Outdated Show resolved Hide resolved

jsuereth and others added 2 commits February 17, 2023 12:45

Update specification/versioning-and-stability.md

453e8a5

Co-authored-by: Johannes Tax <[email protected]>

Add span kind to enforced span conventions.

7594646

reyang reviewed Feb 17, 2023

View reviewed changes

specification/versioning-and-stability.md Outdated Show resolved Hide resolved

yurishkuro reviewed Feb 17, 2023

View reviewed changes

specification/versioning-and-stability.md Outdated Show resolved Hide resolved

specification/versioning-and-stability.md Show resolved Hide resolved

specification/versioning-and-stability.md Show resolved Hide resolved

specification/versioning-and-stability.md Show resolved Hide resolved

lmolkova reviewed Feb 18, 2023

View reviewed changes

specification/versioning-and-stability.md Show resolved Hide resolved

specification/versioning-and-stability.md Outdated Show resolved Hide resolved

lmolkova reviewed Feb 18, 2023

View reviewed changes

specification/versioning-and-stability.md Show resolved Hide resolved

Oberon00 reviewed Feb 21, 2023

View reviewed changes

specification/versioning-and-stability.md Outdated Show resolved Hide resolved

arminru mentioned this pull request Feb 21, 2023

Mark service and telemetry.sdk resource attributes as stable. #3202

Merged

Clarify semantic convention stability.

5a66d17

tigrannajaryan reviewed Feb 21, 2023

View reviewed changes

jsuereth and others added 10 commits February 21, 2023 15:01

Update specification/versioning-and-stability.md

cb088de

Co-authored-by: Tigran Najaryan <[email protected]>

[editorial] Fix Tencent Cloud link (open-telemetry#3231)

e67cdb1

Remove SergeyKanzhelev from auto-assignment (open-telemetry#3229)

bfc0709

Update supplementary-guidelines.md (open-telemetry#3230)

4911aca

[editorial] normalize link to prometheus docs (open-telemetry#3232)

403a298

Co-authored-by: Carlos Alberto Cortez <[email protected]>

Rename faas.execution to faas.invocation_id and change units for …

77137f0

…`faas.max_memory` (open-telemetry#3209)

Add Connect RPC to semantic conventions (open-telemetry#3116)

831a045

* Add connect_rpc to rpc.yaml * Add connect rpc into rpc-metrics and rpc markdown * Add Connect RPC change to CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Armin Ruech <[email protected]>

Update data-model.md (open-telemetry#3233)

87ddbcd

Co-authored-by: Yuri Shkuro <[email protected]>

Add unit to Instrument selection criteria (open-telemetry#3184)

5316e5f

Fix typos and grammar in the OTLP spec (open-telemetry#3121)

75d40a6

jsuereth and others added 4 commits March 2, 2023 11:23

Update specification/versioning-and-stability.md

7e7e626

Co-authored-by: Trask Stalnaker <[email protected]>

Update specification/versioning-and-stability.md

871c103

Co-authored-by: Trask Stalnaker <[email protected]>

Update specification/versioning-and-stability.md

2723805

Co-authored-by: Trask Stalnaker <[email protected]>

Update specification/versioning-and-stability.md

43e083a

Co-authored-by: Trask Stalnaker <[email protected]>

lmolkova mentioned this pull request Mar 3, 2023

Adding new required attributes is a breaking change #3283

Closed

trask approved these changes Mar 3, 2023

View reviewed changes

reyang reviewed Mar 3, 2023

View reviewed changes

specification/versioning-and-stability.md Outdated Show resolved Hide resolved

jack-berg reviewed Mar 3, 2023

View reviewed changes

specification/versioning-and-stability.md Outdated Show resolved Hide resolved

Update specification/versioning-and-stability.md

f27bb26

Co-authored-by: jack-berg <[email protected]>

lmolkova reviewed Mar 6, 2023

View reviewed changes

specification/versioning-and-stability.md Outdated Show resolved Hide resolved

specification/versioning-and-stability.md Outdated Show resolved Hide resolved

Update specification/versioning-and-stability.md

af69829

Co-authored-by: Liudmila Molkova <[email protected]>

jack-berg approved these changes Mar 8, 2023

View reviewed changes

lmolkova approved these changes Mar 8, 2023

View reviewed changes

pyohannes reviewed Mar 8, 2023

View reviewed changes

specification/versioning-and-stability.md Outdated Show resolved Hide resolved

jsuereth and others added 2 commits March 13, 2023 13:18

Merge branch 'main' into pr-metric-stability

5b31117

Another crack at wording improvements.

d496b51

reyang approved these changes Mar 20, 2023

View reviewed changes

Merge branch 'main' into pr-metric-stability

7bc998d

pyohannes approved these changes Mar 21, 2023

View reviewed changes

jsuereth and others added 2 commits March 23, 2023 14:46

Merge branch 'main' into pr-metric-stability

edc7efb

Merge branch 'main' into pr-metric-stability

a9536de

jpkrohling approved these changes Mar 29, 2023

View reviewed changes

jsuereth added 3 commits April 3, 2023 10:06

Merge branch 'main' into pr-metric-stability

2df7d15

Fixes from review and add changelog.

1418d33

Fix markdownlint.

26d1813

jmacd merged commit 713ae0d into open-telemetry:main Apr 3, 2023

jsuereth deleted the pr-metric-stability branch April 3, 2023 16:38

jsuereth mentioned this pull request Jun 26, 2023

Define what constitutes breaking change for Logs #2884

Closed

Oberon00 mentioned this pull request Jun 27, 2023

Moved HTTP semantic conventions to a dedicated topic-based structure open-telemetry/semantic-conventions#141

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide clear guidance on what semconv actually enforces #3225

Provide clear guidance on what semconv actually enforces #3225

jsuereth commented Feb 17, 2023

tigrannajaryan left a comment

lmolkova left a comment •

edited

Loading

Provide clear guidance on what semconv actually enforces #3225

Provide clear guidance on what semconv actually enforces #3225

Conversation

jsuereth commented Feb 17, 2023

Changes

Context

tigrannajaryan left a comment

Choose a reason for hiding this comment

lmolkova left a comment • edited Loading

Choose a reason for hiding this comment

lmolkova left a comment •

edited

Loading