-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos and grammar in the OTLP spec #3121
Fix typos and grammar in the OTLP spec #3121
Conversation
Does this change require a changelog? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fixes @moonbox3
Some of the changes DO change the meaning, so I am temporarily blocking to fix those.
Thank you for your review, @tigrannajaryan. I appreciate it. I have addressed your comments/suggestions. |
Btw we don't use comma after
So we should probably stick to the comma-less form for now, given we already use that and, technically, it's not incorrect. |
@carlosalberto Thank you for your comment. Is there a style guide I should be following? |
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
…nbox3/opentelemetry-specification into otlp-spec-typo-grammar-edits
@tigrannajaryan or @MrAlias can you please help review the final changes? Thank you. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
I would prefer for this PR to not be closed due to lack of activity. Can I get some help on it, please? Thank you. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Thanks @moonbox3 - looks good to go IMHO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 2 small comments left, the rest looks good to me.
Thank you all for the help. @tigrannajaryan I addressed your two final comments. Thank you. |
Thank you @moonbox3 for making the spec clearer. |
Fixes #3120
Changes
This PR fixes typos and grammatical errors in the OTLP spec. Additionally, there were several places where text contained passive voice. These were updated to active voice to make them easier to follow.