Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define what changes are "breaking" for Trace telemetry stability #2883

Closed
jsuereth opened this issue Oct 17, 2022 · 2 comments · Fixed by #3225
Closed

Define what changes are "breaking" for Trace telemetry stability #2883

jsuereth opened this issue Oct 17, 2022 · 2 comments · Fixed by #3225
Assignees
@tedsuo @carlosalberto
Labels
area:semantic-conventions Related to semantic conventions [label deprecated] triaged-needmoreinfo [label deprecated] The issue is triaged - the OTel community needs more information to decide spec:trace Related to the specification/trace directory

Comments

@jsuereth
Copy link
Contributor

Similar to #2864 we need to define / propose what changes to Traces are considered breaking and what are allowable.
@jsuereth jsuereth added area:semantic-conventions Related to semantic conventions spec:trace Related to the specification/trace directory labels Oct 17, 2022
@carlosalberto carlosalberto added the [label deprecated] triaged-needmoreinfo [label deprecated] The issue is triaged - the OTel community needs more information to decide label Oct 24, 2022
@carlosalberto
Copy link
Contributor

Marking as "needs more info" - looking forward to the discussion regarding this item.

@jsuereth
Copy link
Contributor Author

jsuereth commented Oct 30, 2022 •
edited
Loading

@tedsuo FYI - we're hoping to discuss this on Monday in the WG.

For reference here's two things I put together for metrics:

  1. An investigation into aspects of the protocol, with some thoughts on what can/needs to be enforced: sheet
  2. A verbal description of "what's in", "what's out" for stability guarantees and a few things we should discuss. doc

I'm about to do something similar for Logging. Let me know if you need any help fleshing this out.

@trask trask moved this to Blockers for HTTP semconv stability in Semantic Conventions + Instrumentation Stability WG Jan 31, 2023
@jsuereth jsuereth mentioned this issue Feb 17, 2023
Merged
@jsuereth jsuereth moved this from Blocker for HTTP semconv stability to In Progress in Semantic Conventions + Instrumentation Stability WG Mar 20, 2023
jmacd added a commit that referenced this issue Apr 3, 2023
@jsuereth @trask
@pyohannes @tigrannajaryan @chalin @SergeyKanzhelev @carlosalberto @tylerbenson @joshcarp @arminru @yurishkuro @asafm @moonbox3 @jack-berg @atoulme @Oberon00 @lmolkova @reyang @jmacd
Provide clear guidance on what semconv actually enforces (#3225)
713ae0d 
Fixes #2864
Fixes #2883

## Changes

- Explicitly define what is "enforced" by stability guarantees from
Semantic conventions.
- We enforce attribute key names + types, across resource, span, metric
and log
  - We enforce span names
  - We enforce metric names, units
- Expand allowed changes to semconv to include metric attributes that do
not increase timeseries count for a given metric.

## Context

Sig discussion thread/doc
[here](https://docs.google.com/document/d/1Nvcf1wio7nDUVcrXxVUN_f8MNmcs0OzVAZLvlth1lYY/edit?usp=sharing).

---------

Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: Johannes Tax <[email protected]>
Co-authored-by: Tigran Najaryan <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]>
Co-authored-by: Sergey Kanzhelev <[email protected]>
Co-authored-by: Carlos Alberto Cortez <[email protected]>
Co-authored-by: Tyler Benson <[email protected]>
Co-authored-by: Joshua Carpeggiani <[email protected]>
Co-authored-by: Armin Ruech <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Co-authored-by: Asaf Mesika <[email protected]>
Co-authored-by: Evan Mattson <[email protected]>
Co-authored-by: jack-berg <[email protected]>
Co-authored-by: Antoine Toulme <[email protected]>
Co-authored-by: Christian Neumüller <[email protected]>
Co-authored-by: Liudmila Molkova <[email protected]>
Co-authored-by: Reiley Yang <[email protected]>
Co-authored-by: Joshua MacDonald <[email protected]>
carlosalberto added a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 31, 2024
@jsuereth @trask
@pyohannes @tigrannajaryan @chalin @SergeyKanzhelev @carlosalberto @tylerbenson @joshcarp @arminru @yurishkuro @asafm @moonbox3 @jack-berg @atoulme @Oberon00 @lmolkova @reyang @jmacd
Provide clear guidance on what semconv actually enforces (open-teleme…
fa92a4e 
…try#3225)

Fixes open-telemetry#2864
Fixes open-telemetry#2883

## Changes

- Explicitly define what is "enforced" by stability guarantees from
Semantic conventions.
- We enforce attribute key names + types, across resource, span, metric
and log
  - We enforce span names
  - We enforce metric names, units
- Expand allowed changes to semconv to include metric attributes that do
not increase timeseries count for a given metric.

## Context

Sig discussion thread/doc
[here](https://docs.google.com/document/d/1Nvcf1wio7nDUVcrXxVUN_f8MNmcs0OzVAZLvlth1lYY/edit?usp=sharing).

---------

Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: Johannes Tax <[email protected]>
Co-authored-by: Tigran Najaryan <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]>
Co-authored-by: Sergey Kanzhelev <[email protected]>
Co-authored-by: Carlos Alberto Cortez <[email protected]>
Co-authored-by: Tyler Benson <[email protected]>
Co-authored-by: Joshua Carpeggiani <[email protected]>
Co-authored-by: Armin Ruech <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Co-authored-by: Asaf Mesika <[email protected]>
Co-authored-by: Evan Mattson <[email protected]>
Co-authored-by: jack-berg <[email protected]>
Co-authored-by: Antoine Toulme <[email protected]>
Co-authored-by: Christian Neumüller <[email protected]>
Co-authored-by: Liudmila Molkova <[email protected]>
Co-authored-by: Reiley Yang <[email protected]>
Co-authored-by: Joshua MacDonald <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tedsuo tedsuo

@carlosalberto carlosalberto

Labels
area:semantic-conventions Related to semantic conventions [label deprecated] triaged-needmoreinfo [label deprecated] The issue is triaged - the OTel community needs more information to decide spec:trace Related to the specification/trace directory
Projects
Semantic Conventions + Instrumentation Stability WG
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide clear guidance on what semconv actually enforces jsuereth/opentelemetry-specification
3 participants
@tedsuo @jsuereth @carlosalberto