Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify how to deal with invalid numeric envvars #2963

Merged

Conversation

Oberon00
Copy link
Member

@Oberon00 Oberon00 commented Nov 18, 2022

Fixes #2962

Changes

Specify handling of invalid and out-of-range numeric configuration environment variable values.

@Oberon00 Oberon00 requested review from a team November 18, 2022 08:46
@Oberon00 Oberon00 changed the title Specify how to deal with invalid numeric envvars. Specify how to deal with invalid numeric envvars Nov 18, 2022
@Oberon00 Oberon00 added area:sdk Related to the SDK area:configuration Related to configuring the SDK labels Nov 18, 2022
specification/sdk-environment-variables.md Show resolved Hide resolved
specification/sdk-environment-variables.md Outdated Show resolved Hide resolved
specification/sdk-environment-variables.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
specification/sdk-environment-variables.md Outdated Show resolved Hide resolved
@carlosalberto
Copy link
Contributor

Overall good - I'm really hoping nobody uses -1 and similar values as "unlimited" or similar ;)

@reyang reyang merged commit 3ed2087 into open-telemetry:main Nov 28, 2022
@Oberon00 Oberon00 deleted the envvar-numeric-invalid branch January 2, 2023 11:26
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:configuration Related to configuring the SDK area:sdk Related to the SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid numeric configuration environment variable value handling is unspecified
5 participants