-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify how to deal with invalid numeric envvars #2963
Merged
reyang
merged 8 commits into
open-telemetry:main
from
dynatrace-oss-contrib:envvar-numeric-invalid
Nov 28, 2022
Merged
Specify how to deal with invalid numeric envvars #2963
reyang
merged 8 commits into
open-telemetry:main
from
dynatrace-oss-contrib:envvar-numeric-invalid
Nov 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
changed the title
Specify how to deal with invalid numeric envvars.
Specify how to deal with invalid numeric envvars
Nov 18, 2022
Oberon00
added
area:sdk
Related to the SDK
area:configuration
Related to configuring the SDK
labels
Nov 18, 2022
arminru
reviewed
Nov 21, 2022
Co-authored-by: Armin Ruech <[email protected]>
Oberon00
commented
Nov 24, 2022
arminru
approved these changes
Nov 25, 2022
Co-authored-by: Armin Ruech <[email protected]>
carlosalberto
approved these changes
Nov 28, 2022
Overall good - I'm really hoping nobody uses -1 and similar values as "unlimited" or similar ;) |
reyang
approved these changes
Nov 28, 2022
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2962
Changes
Specify handling of invalid and out-of-range numeric configuration environment variable values.