Skip to content

Invalid numeric configuration environment variable value handling is unspecified #2962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Oberon00 opened this issue Nov 18, 2022 · 0 comments · Fixed by #2963
Closed

Invalid numeric configuration environment variable value handling is unspecified #2962

Oberon00 opened this issue Nov 18, 2022 · 0 comments · Fixed by #2963
Assignees
@jsuereth
Labels
area:configuration Related to configuring the SDK area:sdk Related to the SDK [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR spec:miscellaneous For issues that don't match any other spec label

Comments

@Oberon00
Copy link
Member

Oberon00 commented Nov 18, 2022 •
edited
Loading

While all other environment variable value types have a specification for how to deal with invalid/unparseable values, the section for numeric values does not.

See https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/sdk-environment-variables.md

This is what most other value types have:

If (conditions for being invalid) the SDK MUST generate a warning, gracefully ignore the setting and use the default value if it is defined.

This originally came up in #2959 (comment)
@Oberon00 Oberon00 added area:sdk Related to the SDK spec:miscellaneous For issues that don't match any other spec label area:configuration Related to configuring the SDK labels Nov 18, 2022
@Oberon00 Oberon00 changed the title Invalid numeric value handling is unspecified Invalid numeric configuration environment variable value handling is unspecified Nov 18, 2022
This was referenced Nov 18, 2022
Merged
Merged
@carlosalberto carlosalberto added the [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR label Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsuereth jsuereth

Labels
area:configuration Related to configuring the SDK area:sdk Related to the SDK [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR spec:miscellaneous For issues that don't match any other spec label
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Specify how to deal with invalid numeric envvars dynatrace-oss-contrib/opentelemetry-specification
3 participants
@jsuereth @carlosalberto @Oberon00