Limit configuration envvars: unset = empty. #2959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
added
bug
Oberon00
changed the title
Oberon00
force-pushed
the
emptyvar_limit
branch
from
c3a19ac to
abc7e10
Compare
|
I'm not sure if I should add a changelog entry for this, WDYT? |
jack-berg
reviewed
Nov 17, 2022
jack-berg
approved these changes
Nov 17, 2022
reyang
reviewed
Nov 17, 2022
reyang
approved these changes
Nov 18, 2022
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #(no issue)
Changes
Hopefully editorial only:
The spec currently already says in https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/sdk-environment-variables.md#parsing-empty-value:
But then in the limit specification it used to say
This would contradict the above spec, but the empty value is also the default, so the default is infinity, and if it's not set the default is used, so in the end you could interpret this with unset = empty.
However, if you did not see the spec about empty=unset above, there was one interpretation possible where setting the envvar to an empty value would overwrite another value explicitly set via a different configuration source (there is no different source specified at the moment though). This interpretation is now no longer possible.