Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in FailedNotRetryable #243

Merged

Conversation

tigrannajaryan
Copy link
Member

No description provided.

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this duplicated with #241?

@bogdandrutu
Copy link
Member

Approvers please approve this PR. I think this is a trivial (and good) change.

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase.

@tigrannajaryan
Copy link
Member Author

Admins, please merge this.

@Oberon00
Copy link
Member

Oberon00 commented Sep 6, 2019

@tigrannajaryan @tedsuo Maybe one of you can merge this or at least add the ready-to-merge label?

@bogdandrutu bogdandrutu merged commit 68007e4 into open-telemetry:master Sep 7, 2019
bg451 pushed a commit to bg451/opentelemetry-specification that referenced this pull request Sep 9, 2019
yurishkuro pushed a commit that referenced this pull request Sep 13, 2019
* Removes references of spandata

Signed-off-by: Brandon Gonzalez <[email protected]>

* initial stab at tracing spec

Signed-off-by: Brandon Gonzalez <[email protected]>

* adds link and event timestamp

Signed-off-by: Brandon Gonzalez <[email protected]>

* re-add whitespace to reduce diff size

Signed-off-by: Brandon Gonzalez <[email protected]>

* typo fix

Signed-off-by: Brandon Gonzalez <[email protected]>

* Adds OutOfBand flag to span options

Signed-off-by: Brandon Gonzalez <[email protected]>

* specification/api-distributedcontext: fix typo (#236)

contest -> context

Signed-off-by: Brandon Gonzalez <[email protected]>

* Adds comment+link to Remove Out Of Band Support RFC

Signed-off-by: Brandon Gonzalez <[email protected]>

* remove comment in doc

Signed-off-by: Brandon Gonzalez <[email protected]>

* Remove work_in_progress dir (#225)

Signed-off-by: Brandon Gonzalez <[email protected]>

* Move start timestamp above the possibly removed fields

Signed-off-by: Brandon Gonzalez <[email protected]>

* Fix typo in FailedNotRetryable (#243)

Signed-off-by: Brandon Gonzalez <[email protected]>

* Rename TraceOptions to TraceFlags to be w3c compatible (#234)

* Rename TraceOptions to TraceFlags to be w3c compatible

Signed-off-by: Bogdan Drutu <[email protected]>

* Fix more TraceOptions and rename recorded with sampled

Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Brandon Gonzalez <[email protected]>

* Respond to comment
@tigrannajaryan tigrannajaryan deleted the feature/tigran/fixtypo branch September 17, 2019 18:18
SergeyKanzhelev pushed a commit to SergeyKanzhelev/opentelemetry-specification that referenced this pull request Feb 18, 2020
SergeyKanzhelev pushed a commit to SergeyKanzhelev/opentelemetry-specification that referenced this pull request Feb 18, 2020
* Removes references of spandata

Signed-off-by: Brandon Gonzalez <[email protected]>

* initial stab at tracing spec

Signed-off-by: Brandon Gonzalez <[email protected]>

* adds link and event timestamp

Signed-off-by: Brandon Gonzalez <[email protected]>

* re-add whitespace to reduce diff size

Signed-off-by: Brandon Gonzalez <[email protected]>

* typo fix

Signed-off-by: Brandon Gonzalez <[email protected]>

* Adds OutOfBand flag to span options

Signed-off-by: Brandon Gonzalez <[email protected]>

* specification/api-distributedcontext: fix typo (open-telemetry#236)

contest -> context

Signed-off-by: Brandon Gonzalez <[email protected]>

* Adds comment+link to Remove Out Of Band Support RFC

Signed-off-by: Brandon Gonzalez <[email protected]>

* remove comment in doc

Signed-off-by: Brandon Gonzalez <[email protected]>

* Remove work_in_progress dir (open-telemetry#225)

Signed-off-by: Brandon Gonzalez <[email protected]>

* Move start timestamp above the possibly removed fields

Signed-off-by: Brandon Gonzalez <[email protected]>

* Fix typo in FailedNotRetryable (open-telemetry#243)

Signed-off-by: Brandon Gonzalez <[email protected]>

* Rename TraceOptions to TraceFlags to be w3c compatible (open-telemetry#234)

* Rename TraceOptions to TraceFlags to be w3c compatible

Signed-off-by: Bogdan Drutu <[email protected]>

* Fix more TraceOptions and rename recorded with sampled

Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Brandon Gonzalez <[email protected]>

* Respond to comment
TuckTuckFloof pushed a commit to TuckTuckFloof/opentelemetry-specification that referenced this pull request Oct 15, 2020
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 21, 2024
…d Roadmap (open-telemetry#243)

[Easy to read version with images:
[https://github.com/lquerel/oteps/blob/app-telemetry-schema-vision-roadmap/text/0243-app-telemetry-schema-vision-roadmap.md](https://github.com/lquerel/oteps/blob/app-telemetry-schema-vision-roadmap/text/0243-app-telemetry-schema-vision-roadmap.md)]

Unlike the traditional data ecosystem (OLTP and OLAP), the world of
telemetry generally does not rely on the concept of a schema.
Instrumentation is deeply embedded in the code of applications and
libraries, making it difficult to discover all the possible telemetry
signals an application can emit. This gap prevents or limits the
development of CI/CD tools for checking, reporting, documenting, and
generating artifacts from telemetry signals specific to an application.
This document presents a long-term vision aimed at enabling the
OpenTelemetry project to address this issue and extend its impact to a
broader ecosystem. It proposes extending the initiatives of Telemetry
Schema and Semantic Conventions to include concepts of Application
Telemetry Schema and Resolved Telemetry Schema. A series of OTEPs and
Tools will be proposed in this overarching document to detail each
aspect of this vision.

Similar (but proprietary) initiative from Facebook: [Positional Paper:
Schema-First Application
Telemetry](https://research.facebook.com/publications/positional-paper-schema-first-application-telemetry/)

**EDIT 1: The OTel Weaver project (a PoC implementation of this OTEP and
some of the others mentioned in the roadmap) is now available
[here](https://github.com/f5/otel-weaver).**

**EDIT 2: The Slack channel
[#otel-weaver](https://cloud-native.slack.com/archives/C0697EXNTL3) is
dedicated to this OTEP and the associated OTel Weaver project.**

---------

Co-authored-by: Yuri Shkuro <[email protected]>
Co-authored-by: Reiley Yang <[email protected]>
Co-authored-by: Tigran Najaryan <[email protected]>
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 23, 2024
…d Roadmap (open-telemetry#243)

[Easy to read version with images:
[https://github.com/lquerel/oteps/blob/app-telemetry-schema-vision-roadmap/text/0243-app-telemetry-schema-vision-roadmap.md](https://github.com/lquerel/oteps/blob/app-telemetry-schema-vision-roadmap/text/0243-app-telemetry-schema-vision-roadmap.md)]

Unlike the traditional data ecosystem (OLTP and OLAP), the world of
telemetry generally does not rely on the concept of a schema.
Instrumentation is deeply embedded in the code of applications and
libraries, making it difficult to discover all the possible telemetry
signals an application can emit. This gap prevents or limits the
development of CI/CD tools for checking, reporting, documenting, and
generating artifacts from telemetry signals specific to an application.
This document presents a long-term vision aimed at enabling the
OpenTelemetry project to address this issue and extend its impact to a
broader ecosystem. It proposes extending the initiatives of Telemetry
Schema and Semantic Conventions to include concepts of Application
Telemetry Schema and Resolved Telemetry Schema. A series of OTEPs and
Tools will be proposed in this overarching document to detail each
aspect of this vision.

Similar (but proprietary) initiative from Facebook: [Positional Paper:
Schema-First Application
Telemetry](https://research.facebook.com/publications/positional-paper-schema-first-application-telemetry/)

**EDIT 1: The OTel Weaver project (a PoC implementation of this OTEP and
some of the others mentioned in the roadmap) is now available
[here](https://github.com/f5/otel-weaver).**

**EDIT 2: The Slack channel
[#otel-weaver](https://cloud-native.slack.com/archives/C0697EXNTL3) is
dedicated to this OTEP and the associated OTel Weaver project.**

---------

Co-authored-by: Yuri Shkuro <[email protected]>
Co-authored-by: Reiley Yang <[email protected]>
Co-authored-by: Tigran Najaryan <[email protected]>
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
* Removes references of spandata

Signed-off-by: Brandon Gonzalez <[email protected]>

* initial stab at tracing spec

Signed-off-by: Brandon Gonzalez <[email protected]>

* adds link and event timestamp

Signed-off-by: Brandon Gonzalez <[email protected]>

* re-add whitespace to reduce diff size

Signed-off-by: Brandon Gonzalez <[email protected]>

* typo fix

Signed-off-by: Brandon Gonzalez <[email protected]>

* Adds OutOfBand flag to span options

Signed-off-by: Brandon Gonzalez <[email protected]>

* specification/api-distributedcontext: fix typo (open-telemetry#236)

contest -> context

Signed-off-by: Brandon Gonzalez <[email protected]>

* Adds comment+link to Remove Out Of Band Support RFC

Signed-off-by: Brandon Gonzalez <[email protected]>

* remove comment in doc

Signed-off-by: Brandon Gonzalez <[email protected]>

* Remove work_in_progress dir (open-telemetry#225)

Signed-off-by: Brandon Gonzalez <[email protected]>

* Move start timestamp above the possibly removed fields

Signed-off-by: Brandon Gonzalez <[email protected]>

* Fix typo in FailedNotRetryable (open-telemetry#243)

Signed-off-by: Brandon Gonzalez <[email protected]>

* Rename TraceOptions to TraceFlags to be w3c compatible (open-telemetry#234)

* Rename TraceOptions to TraceFlags to be w3c compatible

Signed-off-by: Bogdan Drutu <[email protected]>

* Fix more TraceOptions and rename recorded with sampled

Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Brandon Gonzalez <[email protected]>

* Respond to comment
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
…d Roadmap (open-telemetry#243)

[Easy to read version with images:
[https://github.com/lquerel/oteps/blob/app-telemetry-schema-vision-roadmap/text/0243-app-telemetry-schema-vision-roadmap.md](https://github.com/lquerel/oteps/blob/app-telemetry-schema-vision-roadmap/text/0243-app-telemetry-schema-vision-roadmap.md)]

Unlike the traditional data ecosystem (OLTP and OLAP), the world of
telemetry generally does not rely on the concept of a schema.
Instrumentation is deeply embedded in the code of applications and
libraries, making it difficult to discover all the possible telemetry
signals an application can emit. This gap prevents or limits the
development of CI/CD tools for checking, reporting, documenting, and
generating artifacts from telemetry signals specific to an application.
This document presents a long-term vision aimed at enabling the
OpenTelemetry project to address this issue and extend its impact to a
broader ecosystem. It proposes extending the initiatives of Telemetry
Schema and Semantic Conventions to include concepts of Application
Telemetry Schema and Resolved Telemetry Schema. A series of OTEPs and
Tools will be proposed in this overarching document to detail each
aspect of this vision.

Similar (but proprietary) initiative from Facebook: [Positional Paper:
Schema-First Application
Telemetry](https://research.facebook.com/publications/positional-paper-schema-first-application-telemetry/)

**EDIT 1: The OTel Weaver project (a PoC implementation of this OTEP and
some of the others mentioned in the roadmap) is now available
[here](https://github.com/f5/otel-weaver).**

**EDIT 2: The Slack channel
[#otel-weaver](https://cloud-native.slack.com/archives/C0697EXNTL3) is
dedicated to this OTEP and the associated OTel Weaver project.**

---------

Co-authored-by: Yuri Shkuro <[email protected]>
Co-authored-by: Reiley Yang <[email protected]>
Co-authored-by: Tigran Najaryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants