Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in FailedNotRetryable #516

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Fix typo in FailedNotRetryable #516

merged 1 commit into from
Sep 11, 2019

Conversation

tigrannajaryan
Copy link
Member

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I would suggest to wait for the specs PR to be merged first.

@codecov-io
Copy link

Codecov Report

Merging #516 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #516   +/-   ##
=========================================
  Coverage     79.43%   79.43%           
  Complexity      571      571           
=========================================
  Files            65       65           
  Lines          1921     1921           
  Branches        192      192           
=========================================
  Hits           1526     1526           
  Misses          338      338           
  Partials         57       57
Impacted Files Coverage Δ Complexity Δ
...o/opentelemetry/sdk/trace/export/SpanExporter.java 100% <100%> (ø) 0 <0> (ø) ⬇️
...ntelemetry/sdk/trace/export/MultiSpanExporter.java 100% <100%> (ø) 12 <0> (ø) ⬇️
...lemetry/sdk/trace/export/InMemorySpanExporter.java 100% <100%> (ø) 7 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78e4e10...4006bab. Read the comment docs.

@songy23
Copy link
Member

songy23 commented Sep 11, 2019

Should be good to merge.

@bogdandrutu bogdandrutu merged commit bb44fab into open-telemetry:master Sep 11, 2019
@tigrannajaryan tigrannajaryan deleted the feature/tigran/fixtypo branch September 11, 2019 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants