Rename TraceOptions to TraceFlags to be w3c compatible #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
AloisReitbauer,
c24t,
carlosalberto,
iredelmeier,
reyang,
SergeyKanzhelev,
songy23,
tedsuo and
yurishkuro
as code owners
songy23
approved these changes
Aug 23, 2019
carlosalberto
approved these changes
Aug 26, 2019
|
Ping, I need few more approves |
discostu105
approved these changes
Sep 3, 2019
fbogsany
suggested changes
Sep 3, 2019
fbogsany
approved these changes
Sep 3, 2019
|
Approvers please approve this PR. I think this is a trivial (and good) change. |
tedsuo
approved these changes
Sep 6, 2019
yurishkuro
approved these changes
Sep 7, 2019
bogdandrutu
force-pushed
the
traceflags
branch
from
617541e to
2e032fd
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
traceflags
branch
from
2e032fd to
fa7c566
Compare
bg451
pushed a commit
to bg451/opentelemetry-specification
that referenced
this pull request
Sep 9, 2019
…y#234) * Rename TraceOptions to TraceFlags to be w3c compatible Signed-off-by: Bogdan Drutu <[email protected]> * Fix more TraceOptions and rename recorded with sampled Signed-off-by: Bogdan Drutu <[email protected]> Signed-off-by: Brandon Gonzalez <[email protected]>
songy23
added a commit
to songy23/opentelemetry-java
that referenced
this pull request
Sep 10, 2019
yurishkuro
pushed a commit
that referenced
this pull request
Sep 13, 2019
* Removes references of spandata Signed-off-by: Brandon Gonzalez <[email protected]> * initial stab at tracing spec Signed-off-by: Brandon Gonzalez <[email protected]> * adds link and event timestamp Signed-off-by: Brandon Gonzalez <[email protected]> * re-add whitespace to reduce diff size Signed-off-by: Brandon Gonzalez <[email protected]> * typo fix Signed-off-by: Brandon Gonzalez <[email protected]> * Adds OutOfBand flag to span options Signed-off-by: Brandon Gonzalez <[email protected]> * specification/api-distributedcontext: fix typo (#236) contest -> context Signed-off-by: Brandon Gonzalez <[email protected]> * Adds comment+link to Remove Out Of Band Support RFC Signed-off-by: Brandon Gonzalez <[email protected]> * remove comment in doc Signed-off-by: Brandon Gonzalez <[email protected]> * Remove work_in_progress dir (#225) Signed-off-by: Brandon Gonzalez <[email protected]> * Move start timestamp above the possibly removed fields Signed-off-by: Brandon Gonzalez <[email protected]> * Fix typo in FailedNotRetryable (#243) Signed-off-by: Brandon Gonzalez <[email protected]> * Rename TraceOptions to TraceFlags to be w3c compatible (#234) * Rename TraceOptions to TraceFlags to be w3c compatible Signed-off-by: Bogdan Drutu <[email protected]> * Fix more TraceOptions and rename recorded with sampled Signed-off-by: Bogdan Drutu <[email protected]> Signed-off-by: Brandon Gonzalez <[email protected]> * Respond to comment
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
…y#234) * Rename TraceOptions to TraceFlags to be w3c compatible Signed-off-by: Bogdan Drutu <[email protected]> * Fix more TraceOptions and rename recorded with sampled Signed-off-by: Bogdan Drutu <[email protected]>
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
* Removes references of spandata Signed-off-by: Brandon Gonzalez <[email protected]> * initial stab at tracing spec Signed-off-by: Brandon Gonzalez <[email protected]> * adds link and event timestamp Signed-off-by: Brandon Gonzalez <[email protected]> * re-add whitespace to reduce diff size Signed-off-by: Brandon Gonzalez <[email protected]> * typo fix Signed-off-by: Brandon Gonzalez <[email protected]> * Adds OutOfBand flag to span options Signed-off-by: Brandon Gonzalez <[email protected]> * specification/api-distributedcontext: fix typo (open-telemetry#236) contest -> context Signed-off-by: Brandon Gonzalez <[email protected]> * Adds comment+link to Remove Out Of Band Support RFC Signed-off-by: Brandon Gonzalez <[email protected]> * remove comment in doc Signed-off-by: Brandon Gonzalez <[email protected]> * Remove work_in_progress dir (open-telemetry#225) Signed-off-by: Brandon Gonzalez <[email protected]> * Move start timestamp above the possibly removed fields Signed-off-by: Brandon Gonzalez <[email protected]> * Fix typo in FailedNotRetryable (open-telemetry#243) Signed-off-by: Brandon Gonzalez <[email protected]> * Rename TraceOptions to TraceFlags to be w3c compatible (open-telemetry#234) * Rename TraceOptions to TraceFlags to be w3c compatible Signed-off-by: Bogdan Drutu <[email protected]> * Fix more TraceOptions and rename recorded with sampled Signed-off-by: Bogdan Drutu <[email protected]> Signed-off-by: Brandon Gonzalez <[email protected]> * Respond to comment
TuckTuckFloof
pushed a commit
to TuckTuckFloof/opentelemetry-specification
that referenced
this pull request
Oct 15, 2020
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…y#234) * Rename TraceOptions to TraceFlags to be w3c compatible Signed-off-by: Bogdan Drutu <[email protected]> * Fix more TraceOptions and rename recorded with sampled Signed-off-by: Bogdan Drutu <[email protected]>
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* Removes references of spandata Signed-off-by: Brandon Gonzalez <[email protected]> * initial stab at tracing spec Signed-off-by: Brandon Gonzalez <[email protected]> * adds link and event timestamp Signed-off-by: Brandon Gonzalez <[email protected]> * re-add whitespace to reduce diff size Signed-off-by: Brandon Gonzalez <[email protected]> * typo fix Signed-off-by: Brandon Gonzalez <[email protected]> * Adds OutOfBand flag to span options Signed-off-by: Brandon Gonzalez <[email protected]> * specification/api-distributedcontext: fix typo (open-telemetry#236) contest -> context Signed-off-by: Brandon Gonzalez <[email protected]> * Adds comment+link to Remove Out Of Band Support RFC Signed-off-by: Brandon Gonzalez <[email protected]> * remove comment in doc Signed-off-by: Brandon Gonzalez <[email protected]> * Remove work_in_progress dir (open-telemetry#225) Signed-off-by: Brandon Gonzalez <[email protected]> * Move start timestamp above the possibly removed fields Signed-off-by: Brandon Gonzalez <[email protected]> * Fix typo in FailedNotRetryable (open-telemetry#243) Signed-off-by: Brandon Gonzalez <[email protected]> * Rename TraceOptions to TraceFlags to be w3c compatible (open-telemetry#234) * Rename TraceOptions to TraceFlags to be w3c compatible Signed-off-by: Bogdan Drutu <[email protected]> * Fix more TraceOptions and rename recorded with sampled Signed-off-by: Bogdan Drutu <[email protected]> Signed-off-by: Brandon Gonzalez <[email protected]> * Respond to comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See more details here https://www.w3.org/TR/trace-context/#traceparent-header-field-values