Describe how to convert non-string primitives for protocols which only support strings #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that only support strings
tigrannajaryan
approved these changes
Feb 15, 2022
tigrannajaryan
approved these changes
Feb 15, 2022
jmacd
reviewed
Feb 16, 2022
Co-authored-by: Joshua MacDonald <[email protected]>
jmacd
approved these changes
Feb 22, 2022
aabmass
reviewed
Feb 22, 2022
|
FYI, I have a related open OTEP which tells how to convert from values to OTLP value (the opposite direction of what this PR defines): open-telemetry/oteps#178 |
bogdandrutu
approved these changes
Mar 1, 2022
|
@dashpole I am confused about the changes you mentioned in the description. |
|
@bogdandrutu |
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…y support strings (open-telemetry#2343) * Describe how to handle converting non-string primitives for protocols that only support strings * update wording to make clear that only non-string values are converted to strings * unify language * Update specification/common/common.md Co-authored-by: Joshua MacDonald <[email protected]> Co-authored-by: Joshua MacDonald <[email protected]> Co-authored-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Small change forked from #2266 (comment). Similarly to specifying how to represent arrays, we should specify how to represent primitives as strings if those are not supported. We should use the same string representation for primitive types as we do for primitives within arrays.
I'm not sure if this is actually allowed, since the spec is stable. But since this is a SHOULD, rather than a MUST, it wouldn't require breaking changes. If it isn't permitted, I can just document this in the Prometheus conversion spec itself.
@bogdandrutu I think this would require slight changes to https://github.com/open-telemetry/opentelemetry-collector/blob/30e6bf6eeee544e869411bf50c57447323d259d9/model/pdata/common.go#L370.
cc @jmacd @jsuereth