Use json for writing floats as strings #4934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
json_conversion
branch
from
adb62e2 to
25562d2
Compare
Codecov Report
@@ Coverage Diff @@
## main #4934 +/- ##
==========================================
- Coverage 91.06% 91.04% -0.03%
==========================================
Files 180 180
Lines 10680 10700 +20
==========================================
+ Hits 9726 9742 +16
- Misses 737 740 +3
- Partials 217 218 +1
Continue to review full report at Codecov.
|
bogdandrutu
reviewed
Mar 1, 2022
dashpole
force-pushed
the
json_conversion
branch
2 times, most recently
from
7b87ae9 to
7e5de54
Compare
dashpole
force-pushed
the
json_conversion
branch
4 times, most recently
from
c7d01d5 to
fc5ac27
Compare
|
This is ready for review |
dashpole
force-pushed
the
json_conversion
branch
from
fc5ac27 to
d488758
Compare
bogdandrutu
approved these changes
Mar 16, 2022
|
@dashpole maybe rebase to re-trigger checks? |
dashpole
force-pushed
the
json_conversion
branch
from
0953993 to
f5746c2
Compare
|
pushed again |
|
@dashpole not sure what happens,.... maybe open a new PR from a cloned branch? |
|
it woke up! |
dashpole
force-pushed
the
json_conversion
branch
from
f5746c2 to
d35ed29
Compare
|
rebased |
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this pull request
Jun 7, 2022
* use json for writing floats as strings * avoid using reflection for floats * extra unit test * fix rebase Co-authored-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is the change that would be required by open-telemetry/opentelemetry-specification#2343. It changes how small floats are represented by using the json marshaller. The test would fail with the current implementation, as it returns ".000000009" instead of "9e-9".