Initial Prometheus <-> OTLP datamodel specification. #2266
Conversation
dashpole
force-pushed
the
current-prom-spec
branch
from
cbd0b2b to
2283530
Compare
dashpole
force-pushed
the
current-prom-spec
branch
from
ef6c6e3 to
9321203
Compare
Done |
dashpole
force-pushed
the
current-prom-spec
branch
from
4c7ae2a to
fd49478
Compare
|
@dashpole not sure if prometheus let users set their "job" in the metrics source, but if that is the case probably the library sdk prom exporter should convert "service.name" to "job". Also a separate PR is fine. |
It is possible to set "job" in the metrics source, but by default it will be overwritten by service discovery. |
There was a problem hiding this comment.
The conversions statements here are not made using the normative language conventions this specification is defined to use. Can we update these statements to make clear requirements and recommendations about these conversions?
Done. |
dashpole
force-pushed
the
current-prom-spec
branch
from
879f489 to
aaf9295
Compare
dashpole
force-pushed
the
current-prom-spec
branch
from
7893938 to
98b28b8
Compare
|
This looks like it's ready to go. Please confirm there's no blocker at this moment @brian-brazil @legendecas @anuraaga @jmacd |
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: legendecas <[email protected]>
Co-authored-by: Joshua MacDonald <[email protected]>
…2266) * Initial draft of Prometheus <-> OTLP datamodel specification. * Update specification/metrics/datamodel.md Co-authored-by: Joshua MacDonald <[email protected]> * Add blurb about labels and incompatibilities. * address minor review comments, and fix presubmit failures * update prometheus SD labels based on current state, and update formatting * handle start time and delta sums * add links and headers. Handle exemplars and otel resource attributes. * Apply suggestions from code review Co-authored-by: Anthony Mirabella <[email protected]> * fix link * change prom service discovery section to resource attribute sections * disallow process_start_time_seconds * add links for otel data points * Apply suggestions from code review Co-authored-by: Tyler Yahn <[email protected]> * use normative language * handle negative prometheus histogram buckets * typo * specify what to do with non-string attributes * clarify sum behavior * handle label collisions when converting * clarify that if deltas are not aggregated, they must be dropped * allow process_start_time_seconds, but specify that it must be disabled by default * Update specification/metrics/datamodel.md Co-authored-by: Tyler Yahn <[email protected]> * Update specification/metrics/datamodel.md Co-authored-by: legendecas <[email protected]> * Apply suggestions from code review Co-authored-by: Joshua MacDonald <[email protected]> * describe when process_start_time_seconds isn't correct * convert values to string Co-authored-by: Josh Suereth <[email protected]> Co-authored-by: Josh Suereth <[email protected]> Co-authored-by: Joshua MacDonald <[email protected]> Co-authored-by: Anthony Mirabella <[email protected]> Co-authored-by: Tyler Yahn <[email protected]> Co-authored-by: Anuraag Agrawal <[email protected]> Co-authored-by: legendecas <[email protected]> Co-authored-by: Bogdan Drutu <[email protected]>
This supersedes #2017, and is meant to capture the current state of prometheus support in prometheus SDK exporters and prometheus collector receivers/exporters, rather than the desired end state. This is done to avoid (potentially) contentious debates in the initial draft, and allow tackling these topics individually.
There are a number of changes we will likely want to make after this: