chore: splitting BasePlugin into browser and node #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from node in browser
obecny
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
obecny
added
the
size/L
dyladan
reviewed
Apr 27, 2020
Codecov Report
@@ Coverage Diff @@
## master #981 +/- ##
==========================================
- Coverage 94.95% 94.90% -0.06%
==========================================
Files 210 211 +1
Lines 8571 8576 +5
Branches 772 772
==========================================
Hits 8139 8139
- Misses 432 437 +5
|
This was
linked to
issues
Apr 29, 2020
dyladan
approved these changes
May 7, 2020
mayurkale22
approved these changes
May 7, 2020
| @@ -10,7 +10,7 @@ | |||
| "types": "build/src/index.d.ts", | |||
| "repository": "open-telemetry/opentelemetry-js", | |||
| "scripts": { | |||
| "test": "nyc ts-mocha -p tsconfig.json test/**/*.test.ts", | |||
| "test": "nyc ts-mocha -p tsconfig.json test/**/*.test.ts --exclude 'test/platform/browser/**/*.ts'", | |||
There was a problem hiding this comment.
Just curious to know, why do we have to do this? Also, do you think we should add this to other common packages like api, tracing etc.
There was a problem hiding this comment.
if there are only dedicated tests for browser then this is the way to avoid testing them in mocha. Some of our packages already have things like this, for example collector has common tests and then separate for node and browser.
mayurkale22
added
the
Merge:LGTM
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
…n-telemetry#981) * feat: add new instrumentations into auto-instrumentations-node * test: test to make sure all installed instrumentations are added * fix: register the added instrumentations * test: remove the redundant test * fix: add fs instrumentation back I missed during conflict resolution * fix: add config argument to RouterInstrumentation * style: lint it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes