-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation error in Angular #966
Comments
@obecny I think it may be time to split the BasePlugin into specific node/web versions |
/cc @mayurkale22 |
we can just split it to 3 files, base abstract and then node and web using the platform folder ? |
Just wondering what has changed recently that this is not working anymore ?. As it was fine quite recently |
It's probably some issue with his specific bundler or something like that. The BasePlugin definitely uses the |
anyway we should split it asap ;) |
@gpra the fix for this should go out with the release today |
What version of OpenTelemetry are you using?
0.6.1
What version of Node are you using?
13.11.0
What did you do?
Tried to use @opentelemetry in an Angular project. Just:
1 - include the dependency:
2 - Try to use it:
import { SimpleSpanProcessor } from '@opentelemetry/tracing';
What did you expect to see?
Compile OK
What did you see instead?
Compilation error:
ERROR in ./node_modules/@opentelemetry/core/build/src/trace/instrumentation/BasePlugin.js
Module not found: Error: Can't resolve 'path' in './node_modules/@opentelemetry/core/build/src/trace/instrumentation'
Additional context
File "@opentelemetry/core/build/src/trace/instrumentation/BasePlugin.js", line 19 imports "path":
const path = require("path");
Commenting lines 19, 77 and 80 solves the problem.
The text was updated successfully, but these errors were encountered: