Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Platform specific BasePlugin #967

Closed
dyladan opened this issue Apr 15, 2020 · 0 comments · Fixed by #981
Closed

Platform specific BasePlugin #967

dyladan opened this issue Apr 15, 2020 · 0 comments · Fixed by #981
Assignees
@obecny
Labels
feature-request

Comments

@dyladan
Copy link
Member

dyladan commented Apr 15, 2020

Some web bundlers complain or do not properly tree-shake out the node specific parts of the BasePlugin. Further, the web does not automatically enable plugins. We should create platform specific implementations which only implement the features needed for the platform.
This was referenced Apr 23, 2020
Closed
Merged
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@nozik @rauno56
feat: send log level to pino hook (open-telemetry#967)
cfb0b7a 
* send log level to pino hook
* add comment to hook log, change to semver.satisfies

Co-authored-by: Rauno Viskus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obecny obecny

Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: splitting BasePlugin into browser and node obecny/opentelemetry-js
2 participants
@obecny @dyladan