-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propose to add @obecny as the CODEOWNERS. #505
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
bg451,
danielkhan,
markwolff,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
November 7, 2019 17:45
markwolff
approved these changes
Nov 7, 2019
Codecov Report
@@ Coverage Diff @@
## master #505 +/- ##
==========================================
+ Coverage 88.54% 92.68% +4.13%
==========================================
Files 116 135 +19
Lines 5561 6682 +1121
Branches 502 596 +94
==========================================
+ Hits 4924 6193 +1269
+ Misses 637 489 -148
|
vmarchaud
approved these changes
Nov 8, 2019
bogdandrutu
reviewed
Nov 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably need to add them to the list of approvers and in the approver team
dyladan
approved these changes
Nov 8, 2019
mayurkale22
force-pushed
the
new_codeowner
branch
from
November 8, 2019 18:41
7ba0063
to
7dc2ed5
Compare
Sure, done. |
mayurkale22
force-pushed
the
new_codeowner
branch
from
November 8, 2019 21:09
7dc2ed5
to
19b1bbe
Compare
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
* chore: add @obecny in CODEOWNERS * chore: update approvers list
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Co-authored-by: Valentin Marchaud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
@obecny has showed strong interest and commitment in the OpenTelemetry Web SDKs and Plugins. Currently, he is the main contributor for Web SDKs. We really appreciate his work! Thank you for all the contributions.
Notable PRs Tracer web #334, feat(scope-zone): new scope manager to support async operations in web #461, feat(traceparent): setting parent span from server #477, feat(plugin-document-load): new plugin for document load for web tracer #433, Fix karma coverage for browsers tests #455, Use Sinon Fake Timers to improve and speed up tests #447, Add new ZoneScopeManager for web #435, Allow specifying a timestamp when creating Events #438.
Involved in SIG meetings.