Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying a timestamp when creating Events #438

Closed
mayurkale22 opened this issue Oct 17, 2019 · 2 comments · Fixed by #433
Closed

Allow specifying a timestamp when creating Events #438

mayurkale22 opened this issue Oct 17, 2019 · 2 comments · Fixed by #433
Assignees
Labels
Milestone

Comments

@mayurkale22
Copy link
Member

Based on the issue: #213

The spec defines an Event as follows:

A Span MUST have the ability to add events. Events have a time associated with the moment when they are added to the Span.

Please update the API and corresponding SDK implementation(s).

/**
* Adds an event to the Span.
*
* @param name the name of the event.
* @param [attributes] the attributes that will be added; these are
* associated with this event.
*/
addEvent(name: string, attributes?: Attributes): this;

@obecny
Copy link
Member

obecny commented Oct 18, 2019

@mayurkale22 would that make sense if I take it and make necessary changes so that I can finish the document-load plugin by adding time for events as discussed with @draffensperger in PR #433 ?

@mayurkale22
Copy link
Member Author

Sure, I have assigned to you. Thank you 😊

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants