Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ZoneScopeManager for web #435

Closed
obecny opened this issue Oct 15, 2019 · 2 comments · Fixed by #461
Closed

Add new ZoneScopeManager for web #435

obecny opened this issue Oct 15, 2019 · 2 comments · Fixed by #461
Assignees
Milestone

Comments

@obecny
Copy link
Member

obecny commented Oct 15, 2019

If you have any suggestions, thoughts, things I should be aware of when implementing the new ZoneScopeManager that will support async operations please share it, thank you.

@obecny
Copy link
Member Author

obecny commented Oct 15, 2019

cc @mayurkale22 @draffensperger

@draffensperger
Copy link
Contributor

I think we could base this loosely on the OpenCensus Web tracer that uses Zone.js.

Also, I think the core functionality of the scope manager should bring in Zone.js as a peerDependency, and call the package something like opentelemetry-scope-zone-peer-dep. The advantage of that is that for Angular apps that bring in Zone.js already, there are no issues around version skew or problems around bringing in the Zone.js library twice.

That said, for non-Angular apps (the majority!), we could have a more convenient package opentelemetry-scope-zone that just composes opentelemetry-scope-zone-peer-dep with the Zone.js package itself. We could clearly document which package to use when based on whether your app already includes the Zone.js dependency.

We did this for OpenCensus Web, see https://github.com/census-instrumentation/opencensus-web#using-as-npm-dependency-in-existing-js-build in the second bullet point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants