-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make logger property public instead of private in BasicTracer #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
danielkhan,
iredelmeier and
rochdev
as code owners
August 22, 2019 18:42
draffensperger
approved these changes
Aug 22, 2019
OlivierAlbertini
approved these changes
Aug 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
markwolff
approved these changes
Aug 22, 2019
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
=========================================
+ Coverage 93.92% 94.22% +0.3%
=========================================
Files 47 48 +1
Lines 1645 1750 +105
Branches 109 118 +9
=========================================
+ Hits 1545 1649 +104
- Misses 100 101 +1
|
danielkhan
approved these changes
Aug 26, 2019
mayurkale22
force-pushed
the
public_logger
branch
from
August 26, 2019 17:24
fe7c8b3
to
a7481c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
Logger
is private property inBasicTracer
class, in current scenario we have to pass logger everywhere. Making it public solves this problem.