Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make logger property public instead of private in BasicTracer #213

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

mayurkale22
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • The Logger is private property in BasicTracer class, in current scenario we have to pass logger everywhere. Making it public solves this problem.

@mayurkale22
Copy link
Member Author

/cc @OlivierAlbertini

Copy link
Member

@OlivierAlbertini OlivierAlbertini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@codecov-io
Copy link

codecov-io commented Aug 23, 2019

Codecov Report

Merging #213 into master will increase coverage by 0.3%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #213     +/-   ##
=========================================
+ Coverage   93.92%   94.22%   +0.3%     
=========================================
  Files          47       48      +1     
  Lines        1645     1750    +105     
  Branches      109      118      +9     
=========================================
+ Hits         1545     1649    +104     
- Misses        100      101      +1
Impacted Files Coverage Δ
packages/opentelemetry-basic-tracer/src/Span.ts 100% <100%> (ø) ⬆️
...ages/opentelemetry-basic-tracer/src/BasicTracer.ts 98.14% <100%> (ø) ⬆️
...kages/opentelemetry-basic-tracer/test/Span.test.ts 100% <100%> (ø) ⬆️
...ckages/opentelemetry-core/src/common/NoopLogger.ts 14.28% <0%> (-5.72%) ⬇️
...s/opentelemetry-core/test/trace/tracestate.test.ts 100% <0%> (ø) ⬆️
...lemetry-core/test/trace/ProbabilitySampler.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-core/src/trace/spancontext-utils.ts 100% <0%> (ø) ⬆️
...s/opentelemetry-core/test/trace/NoopTracer.test.ts 100% <0%> (ø) ⬆️
...ckages/opentelemetry-core/test/platform/id.test.ts 100% <0%> (ø) ⬆️
... and 11 more

@open-telemetry open-telemetry deleted a comment from codecov-io Aug 23, 2019
@open-telemetry open-telemetry deleted a comment from codecov-io Aug 23, 2019
@open-telemetry open-telemetry deleted a comment from codecov-io Aug 23, 2019
@open-telemetry open-telemetry deleted a comment from codecov-io Aug 23, 2019
@open-telemetry open-telemetry deleted a comment from codecov-io Aug 23, 2019
@open-telemetry open-telemetry deleted a comment from codecov-io Aug 23, 2019
@open-telemetry open-telemetry deleted a comment from codecov-io Aug 23, 2019
@open-telemetry open-telemetry deleted a comment from codecov-io Aug 23, 2019
@open-telemetry open-telemetry deleted a comment from codecov-io Aug 23, 2019
@open-telemetry open-telemetry deleted a comment from codecov-io Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make logger property public instead of private in BasicTracer class
6 participants